Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-47230: Silence new compiler warnings from updated zlib #32337

Merged
merged 1 commit into from Apr 5, 2022
Merged

bpo-47230: Silence new compiler warnings from updated zlib #32337

merged 1 commit into from Apr 5, 2022

Conversation

jkloth
Copy link
Contributor

@jkloth jkloth commented Apr 5, 2022 •
edited by bedevere-bot

@jkloth jkloth requested a review from as a code owner Apr 5, 2022
@zooba zooba added the skip news label Apr 5, 2022
@zooba zooba merged commit 944f09a into python:main Apr 5, 2022
11 checks passed
@miss-islington
Copy link

@miss-islington miss-islington commented Apr 5, 2022

Thanks @jkloth for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link

@miss-islington miss-islington commented Apr 5, 2022

Thanks @jkloth for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link

@miss-islington miss-islington commented Apr 5, 2022

Sorry @jkloth and @zooba, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 944f09adfcc59f54432ac2947cf95f3465d90e1e 3.9

@miss-islington
Copy link

@miss-islington miss-islington commented Apr 5, 2022

Sorry, @jkloth and @zooba, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 944f09adfcc59f54432ac2947cf95f3465d90e1e 3.10

jkloth added a commit to jkloth/cpython that referenced this issue Apr 5, 2022
@jkloth
[3.9] bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (
a4af94f 
pythonGH-32337).

(cherry picked from commit 944f09a)

Co-authored-by: Jeremy Kloth <jeremy.kloth@gmail.com>
@jkloth jkloth mentioned this pull request Apr 5, 2022
Merged
jkloth added a commit to jkloth/cpython that referenced this issue Apr 5, 2022
@jkloth
[3.10] bpo-47230: Silence compiler warnings on Windows from zlib 1.2.…
d0be4c7 
…12 (pythonGH-32337).

(cherry picked from commit 944f09a)

Co-authored-by: Jeremy Kloth <jeremy.kloth@gmail.com>
@jkloth jkloth mentioned this pull request Apr 5, 2022
Merged
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 5, 2022

GH-32347 is a backport of this pull request to the 3.10 branch.

@jkloth jkloth deleted the issue47230 branch Apr 5, 2022
zooba pushed a commit that referenced this issue Apr 5, 2022
@jkloth
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-…
8bce3cb 
…32337)

(cherry picked from commit 944f09a)

Co-authored-by: Jeremy Kloth <jeremy.kloth@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 5, 2022

GH-32346 is a backport of this pull request to the 3.9 branch.

zooba pushed a commit that referenced this issue Apr 5, 2022
@jkloth
bpo-47230: Silence compiler warnings on Windows from zlib 1.2.12 (GH-…
a4c7752 
…32337)

(cherry picked from commit 944f09a)

Co-authored-by: Jeremy Kloth <jeremy.kloth@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees

@zooba zooba

Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jkloth @miss-islington @bedevere-bot @zooba @the-knights-who-say-ni