Skip to content

Make DHCP more user-friendly #3494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2022
Merged

Make DHCP more user-friendly #3494

merged 1 commit into from
Jun 7, 2022

Conversation

gpotter2
Copy link
Member

@gpotter2 gpotter2 commented Dec 25, 2021

  • Greatly improve readability of DHCP fields while retaining backward compatibility
  • Improve dhcp_request to support both Discovery and Request packets

@codecov
Copy link

codecov bot commented Dec 25, 2021

Codecov Report

Merging #3494 (922c59a) into master (064e0d2) will increase coverage by 0.14%.
The diff coverage is 37.73%.

@@            Coverage Diff             @@
##           master    #3494      +/-   ##
==========================================
+ Coverage   86.01%   86.16%   +0.14%     
==========================================
  Files         285      285              
  Lines       64983    65013      +30     
==========================================
+ Hits        55896    56018     +122     
+ Misses       9087     8995      -92     
Impacted Files Coverage Δ
scapy/layers/dhcp.py 80.62% <29.41%> (-6.67%) ⬇️
scapy/fields.py 91.16% <50.00%> (+0.14%) ⬆️
scapy/layers/l2.py 76.63% <100.00%> (+0.75%) ⬆️
scapy/packet.py 82.13% <0.00%> (+0.07%) ⬆️
scapy/volatile.py 85.94% <0.00%> (+0.11%) ⬆️
scapy/utils.py 76.90% <0.00%> (+0.12%) ⬆️
scapy/pipetool.py 84.32% <0.00%> (+0.22%) ⬆️
scapy/layers/ntp.py 84.82% <0.00%> (+0.27%) ⬆️
scapy/contrib/automotive/scanner/enumerator.py 92.26% <0.00%> (+0.29%) ⬆️
... and 7 more

polybassa
polybassa previously approved these changes Feb 9, 2022
@polybassa
Copy link
Contributor

LGTM

@gpotter2
Copy link
Member Author

gpotter2 commented Jun 7, 2022

This is also ready for review @guedou @p-l- ! (and fairly simple)

@p-l- p-l- merged commit b3726ca into secdev:master Jun 7, 2022
@gpotter2 gpotter2 deleted the fancy-dhcp branch June 7, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants