Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: auto-push patch file changes #26235

Merged
merged 6 commits into from Oct 29, 2020
Merged

build: auto-push patch file changes #26235

merged 6 commits into from Oct 29, 2020

Conversation

MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 28, 2020

Small bit of code to auto push three way merge patch file changes from CI. Abuses a GH app to do it similar to how trop works

Notes: no-notes

@MarshallOfSound MarshallOfSound requested a review from as a code owner Oct 28, 2020
nornagon
nornagon approved these changes Oct 28, 2020
View changes
Copy link
Member

@nornagon nornagon left a comment

noice

patches/chromium/rename_the_v8_context_snapshot_on_arm64_macos_builds.patch Outdated Show resolved Hide resolved
jkleinsc
jkleinsc approved these changes Oct 28, 2020
View changes
Copy link
Contributor

@jkleinsc jkleinsc left a comment

LGTM -- just needs linting.

ckerr
ckerr approved these changes Oct 28, 2020
View changes
Copy link
Member

@ckerr ckerr left a comment

🎉

@electron electron deleted a comment from nornagon Oct 28, 2020
@jkleinsc
Copy link
Contributor

@jkleinsc jkleinsc commented Oct 29, 2020

Merging as Mac failure is flake unrelated to this PR.

@jkleinsc jkleinsc merged commit 07ee75b into master Oct 29, 2020
14 of 15 checks passed
@release-clerk
Copy link

@release-clerk release-clerk bot commented Oct 29, 2020

No Release Notes

@jkleinsc jkleinsc deleted the push-patches branch Oct 29, 2020
@nornagon
Copy link
Member

@nornagon nornagon commented Oct 29, 2020

/trop run backport

@trop
Copy link
Contributor

@trop trop bot commented Oct 29, 2020

The backport process for this PR has been manually initiated, here we go! :D

@trop
Copy link
Contributor

@trop trop bot commented Oct 29, 2020

I was unable to backport this PR to "10-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/10-x-y label Oct 29, 2020
@trop
Copy link
Contributor

@trop trop bot commented Oct 29, 2020

I was unable to backport this PR to "11-x-y" cleanly;
you will need to perform this backport manually.

@trop
Copy link
Contributor

@trop trop bot commented Oct 29, 2020

I was unable to backport this PR to "8-x-y" cleanly;
you will need to perform this backport manually.

@trop trop bot removed the target/8-x-y label Nov 10, 2020
@trop
Copy link
Contributor

@trop trop bot commented Nov 10, 2020

I was unable to backport this PR to "9-x-y" cleanly;
you will need to perform this backport manually.

MarshallOfSound added a commit that referenced this issue Nov 10, 2020
@MarshallOfSound @MarshallOfSound
build: auto-push patch file changes (#26235)
cc7e67d 
* build: auto-push patch file changes

* chore: change patch for testing purposes

* build: remove stray log

* build: push as electron bot

* build: suppress all output of the push-patch script

* chore: fix linting
@MarshallOfSound MarshallOfSound mentioned this pull request Nov 10, 2020
Merged
@trop
Copy link
Contributor

@trop trop bot commented Nov 10, 2020

@MarshallOfSound has manually backported this PR to "11-x-y", please check out #26431

MarshallOfSound added a commit that referenced this issue Nov 10, 2020
@MarshallOfSound @MarshallOfSound
build: auto-push patch file changes (#26235)
63447f5 
* build: auto-push patch file changes

* chore: change patch for testing purposes

* build: remove stray log

* build: push as electron bot

* build: suppress all output of the push-patch script

* chore: fix linting
@MarshallOfSound MarshallOfSound mentioned this pull request Nov 10, 2020
Merged
@trop
Copy link
Contributor

@trop trop bot commented Nov 10, 2020

@MarshallOfSound has manually backported this PR to "10-x-y", please check out #26433

MarshallOfSound added a commit that referenced this issue Nov 10, 2020
@MarshallOfSound @MarshallOfSound
build: auto-push patch file changes (#26235)
031444d 
* build: auto-push patch file changes

* chore: change patch for testing purposes

* build: remove stray log

* build: push as electron bot

* build: suppress all output of the push-patch script

* chore: fix linting
@MarshallOfSound MarshallOfSound mentioned this pull request Nov 10, 2020
Merged
@trop
Copy link
Contributor

@trop trop bot commented Nov 10, 2020

@MarshallOfSound has manually backported this PR to "9-x-y", please check out #26434

MarshallOfSound added a commit that referenced this issue Nov 10, 2020
@MarshallOfSound
build: auto-push patch file changes (#26235) (#26431)
9c9e402 
* build: auto-push patch file changes

* chore: change patch for testing purposes

* build: remove stray log

* build: push as electron bot

* build: suppress all output of the push-patch script

* chore: fix linting
@trop trop bot removed the in-flight/10-x-y label Nov 10, 2020
MarshallOfSound added a commit that referenced this issue Nov 10, 2020
@MarshallOfSound
build: auto-push patch file changes (#26235) (#26433)
4aa4d19 
* build: auto-push patch file changes

* chore: change patch for testing purposes

* build: remove stray log

* build: push as electron bot

* build: suppress all output of the push-patch script

* chore: fix linting
MarshallOfSound added a commit that referenced this issue Nov 10, 2020
@MarshallOfSound
build: auto-push patch file changes (#26235) (#26434)
d94a5dd 
* build: auto-push patch file changes

* chore: change patch for testing purposes

* build: remove stray log

* build: push as electron bot

* build: suppress all output of the push-patch script

* chore: fix linting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr

@nornagon nornagon

@jkleinsc jkleinsc

Assignees
No one assigned
Labels
merged/9-x-y merged/10-x-y merged/11-x-y
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MarshallOfSound @jkleinsc @nornagon @ckerr @codebytere