Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bpo-44800: Document internal frame naming conventions" #32301

Merged
merged 1 commit into from Apr 4, 2022

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Apr 4, 2022

Reverts #32281 as it is both misleading in general and incorrect in detail.

General:
Listing each field, and stating its name, is pointless and just gets in the way of reading the code which contains the same information and is guaranteed unambiguous and up to date.
The language is vague, and is misleading when describing why there are two structs, PyInterpeterFrame, and PyFrameObject and what their roles are.

Detail:
There is no f_state field (and f_lasti will be replaced imminently).

https://bugs.python.org/issue44800

@markshannon markshannon merged commit 8a349eb into main Apr 4, 2022
11 checks passed
@markshannon markshannon deleted the revert-32281-bpo-44800-document-status-quo branch Apr 4, 2022
@bedevere-bot
Copy link

bedevere-bot commented Apr 4, 2022

@markshannon: Please replace # with GH- in the commit message next time. Thanks!

@markshannon
Copy link
Member Author

markshannon commented Apr 4, 2022

See #32304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants