Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated text for iterable unpacking #25212

Merged
merged 2 commits into from Apr 3, 2022
Merged

Conversation

jiasli
Copy link
Contributor

@jiasli jiasli commented Apr 6, 2021

This text is duplicated several lines later:

* Else: The object must be an iterable with the same number of items as there
are targets in the target list, and the items are assigned, from left to
right, to the corresponding targets.

Putting it after the first Else: causes confusion.

@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Apr 6, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@jiasli

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@jiasli jiasli changed the title Remove duplicated text Remove duplicated text for iterable unpacking Apr 6, 2021
@Numerlor
Copy link
Contributor

@Numerlor Numerlor commented Apr 25, 2021

I don't think the else and indentation really improves the readability of the text here as it is implied by it being an another condition. For example something like this would suffice in my opinion

Assignment of an object to a target list, optionally enclosed in parentheses or
square brackets, is recursively defined as follows.

* If the target list is a single target with no trailing comma,
  optionally in parentheses, the object is assigned to that target.

* If the target list contains one target prefixed with an asterisk, called a
  "starred" target: <...>

* Otherwise the object must be an iterable with the same number of items as there
  are targets in the target list, and the items are assigned, from left to
  right, to the corresponding targets.

@jiasli
Copy link
Contributor Author

@jiasli jiasli commented May 8, 2021

@Numerlor, I agree, but I only want to eliminate duplication in this PR as it is obviously wrong. As for the content itself, I will leave it to the python maintainer.

@github-actions
Copy link

@github-actions github-actions bot commented Jun 8, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Jun 8, 2021
@JelleZijlstra JelleZijlstra self-requested a review Apr 2, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 3, 2022

Thanks @jiasli for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 3, 2022

GH-32277 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 3, 2022

GH-32278 is a backport of this pull request to the 3.9 branch.

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Apr 3, 2022

Thanks for your contribution, and sorry it had to wait for so long!

miss-islington added a commit to miss-islington/cpython that referenced this issue Apr 3, 2022
…ythonGH-25212)

(cherry picked from commit 4f5d56f8f33196f5ed8ffad0ab2f012afda2f9b3)

Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
miss-islington added a commit that referenced this issue Apr 3, 2022
…H-25212)

(cherry picked from commit 4f5d56f)

Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
miss-islington added a commit that referenced this issue Apr 3, 2022
…H-25212)

(cherry picked from commit 4f5d56f)

Co-authored-by: Jiashuo Li <4003950+jiasli@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed docs skip issue skip news stale
Projects
None yet
6 participants