Skip to content

gh-72631: Fix wrong documentation for GzipFile.peek #29820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 10, 2025
Merged

gh-72631: Fix wrong documentation for GzipFile.peek #29820

merged 7 commits into from
Apr 10, 2025

Conversation

180909
Copy link
Contributor

@180909 180909 commented Nov 28, 2021 •
edited by erlend-aasland
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Nov 28, 2021
arhadthedev
arhadthedev reviewed Nov 28, 2021
View reviewed changes
@github-actions

This comment was marked as outdated.

Sign in to view
@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 29, 2021
MaxwellDupre
MaxwellDupre approved these changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds about right.

JelleZijlstra
JelleZijlstra reviewed Apr 2, 2022
View reviewed changes
@abacabadabacaba abacabadabacaba mannequin mentioned this pull request Apr 10, 2022
Closed
@slateny
Copy link
Contributor

slateny commented Oct 25, 2022

@180909 Would you be interested in modifying the PR a bit to address the review?

@hugovk hugovk added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 11, 2023
@erlend-aasland erlend-aasland changed the title bpo-28445: Fix wrong documentation for GzipFile.peek gh-72631: Fix wrong documentation for GzipFile.peek Mar 31, 2024
@hugovk hugovk removed the needs backport to 3.11 only security fixes label Apr 11, 2024
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.13 bugs and security fixes label May 9, 2024
@StanFromIreland
Copy link
Contributor

This PR seems to have been forgotten...

@furkanonder furkanonder requested a review from willingc December 13, 2024 00:07
@furkanonder furkanonder removed the stale Stale PR or inactive for long period of time. label Dec 13, 2024
@hugovk hugovk removed the needs backport to 3.12 only security fixes label Apr 10, 2025
@hugovk hugovk merged commit 6535703 into python:main Apr 10, 2025
31 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Apr 10, 2025
@miss-islington-app
Copy link

Thanks @180909 for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 10, 2025
@180909 @hugovk
@erlend-aasland @miss-islington
pythongh-72631: Fix wrong documentation for GzipFile.peek (pythonGH-2…
1677a6f 
…9820)

(cherry picked from commit 6535703)

Co-authored-by: 180909 <wjh180909@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-app
Copy link

bedevere-app bot commented Apr 10, 2025

GH-132353 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Apr 10, 2025
hugovk added a commit that referenced this pull request Apr 10, 2025
@miss-islington @180909
@hugovk @erlend-aasland
[3.13] gh-72631: Fix wrong documentation for GzipFile.peek (GH-29820) (…
b328e4b 
…#132353)

Co-authored-by: 180909 <wjh180909@gmail.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
seehwan pushed a commit to seehwan/cpython that referenced this pull request Apr 16, 2025
@180909 @hugovk
@erlend-aasland @seehwan80
pythongh-72631: Fix wrong documentation for GzipFile.peek (python#29820)
86b6af1 
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@arhadthedev arhadthedev arhadthedev left review comments

@MaxwellDupre MaxwellDupre MaxwellDupre approved these changes

@furkanonder furkanonder furkanonder approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@willingc willingc Awaiting requested review from willingc

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.