Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-90915: Document that SystemExit doesn't trigger sys.excepthook #31357

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cjwatson
Copy link
Contributor

@cjwatson cjwatson commented Feb 15, 2022

This was documented in help(sys), but not in the main library
documentation.

https://bugs.python.org/issue46759

This was documented in `help(sys)`, but not in the main library
documentation.
@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 15, 2022
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change but worthy.

before the program exits. The handling of such top-level exceptions can be
customized by assigning another three-argument function to ``sys.excepthook``.
When an exception other than :exc:`SystemExit` is raised and uncaught,
the interpreter calls ``sys.excepthook`` with three arguments, the
Copy link
Contributor

@slateny slateny Oct 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the lines after the addition of SystemExit don't change, I'd say just make a new line even though it might be shorter than the rest so checking diff is easier

@kumaraditya303 kumaraditya303 changed the title bpo-46759: Document that SystemExit doesn't trigger sys.excepthook GH-90915: Document that SystemExit doesn't trigger sys.excepthook Jan 5, 2023
@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Jan 5, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting core review docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants