Skip to content

/ vue-test-utils

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

attachToDocument - outdated deprecation warning #1725

Open
Mikilll94 opened this issue Oct 25, 2020 · 1 comment
Open

attachToDocument - outdated deprecation warning #1725

Mikilll94 opened this issue Oct 25, 2020 · 1 comment
Labels
good first issue

Comments

@Mikilll94
Copy link

@Mikilll94 Mikilll94 commented Oct 25, 2020

Documentation Feedback

Screenshot 2020-10-25 at 12 33 14

I think this deprecation warning is outdated. After discussion in #1578, the recommended way to replace attachToDocument: true should be attachTo: document.body.

Affected documentation page:

https://vue-test-utils.vuejs.org/api/options.html#attachtodocument
@Mikilll94 Mikilll94 changed the title Outdated deprecation warning attachToDocument - outdated deprecation warning Oct 25, 2020
@afontcu
Copy link
Member

@afontcu afontcu commented Oct 26, 2020

Sounds about right! Fancy to open up a PR? 🙌
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@afontcu @Mikilll94
You can’t perform that action at this time.