Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After the revert of 7cf9b94 we've identified a need to add a lint that checks file names to ensure that they're compatible with Windows machines.
Observed error: (from example commit)
Error: error: invalid path 'test/test_ops_gradients.py '
A simple check on changed files to ensure that the file paths do not include trailing whitespace should be sufficient enough for this.
A good place to start to add this would be here: https://github.com/pytorch/pytorch/blob/master/.github/workflows/lint.yml
No response
This could potentially be expanded to include a litany of lints that check for compatibility on Windows. (see git-for-windows/git#2777 for more context)
cc @seemethere @malfet @pytorch/pytorch-dev-infra
The text was updated successfully, but these errors were encountered:
Hi, I would like to work on this issue
Sorry, something went wrong.
Successfully merging a pull request may close this issue.
After the revert of 7cf9b94 we've identified a need to add a lint that checks file names to ensure that they're compatible with Windows machines.
Observed error: (from example commit)
A simple check on changed files to ensure that the file paths do not include trailing whitespace should be sufficient enough for this.
A good place to start to add this would be here: https://github.com/pytorch/pytorch/blob/master/.github/workflows/lint.yml
Alternatives
No response
Additional context
This could potentially be expanded to include a litany of lints that check for compatibility on Windows. (see git-for-windows/git#2777 for more context)
cc @seemethere @malfet @pytorch/pytorch-dev-infra
The text was updated successfully, but these errors were encountered: