bpo-46033: Clarify for-statement execution #30025
Conversation
|
Please let us know when you have signed the CLA. It might take a few days to be recorded. |
|
@terryjreedy done. Forgot to check myself. |
|
@terryjreedy I added news entry to make Azure Pipelines PR check green. CLA is also signed. |
|
@michcio1234 there is a merge conflict now, could you take a look? Also, I don't think this change needs a NEWS entry. I added the "skip news" label so CI won't fail if you remove the NEWS entry you added. |
terryjreedy
changed the title
There was a problem hiding this comment.
If the change was to just remove a sentence, then no news would be needed. But we did something else, and I made more edits to blend with the other, conflicting merge. Hence I changed both title and news.
I think this is ready, but please read to check.
Note: the other addition was not backported, so this cannot be either.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
|
I will re-approve with 2 links added (if you agree) and removal of sentence as suggested. |
|
Will merge after checking generated .html on my machine. |
|
@terryjreedy @JelleZijlstra thank you very much for taking care of this and sorry for not responding lately. Glad that something useful came out of this. :) |
In for statement description, there seem to be two sentences meant to mean the same:
(from https://docs.python.org/3/reference/compound_stmts.html#the-for-statement)
I modified this text to be - in my opinion - cleaner.
If I am wrong, and the current version is actually correct, then it is unclear - to me it sounds like the iterator is iterated through twice, and suite is executed twice for each item.
https://bugs.python.org/issue46033