Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-45847: Port _ctypes partly to PY_STDLIB_MOD #32229

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Copy link
Member

@tiran tiran commented Apr 1, 2022

Co-authored-by: Erlend Egeberg Aasland erlend.aasland@innova.no

https://bugs.python.org/issue45847

@arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented Apr 1, 2022

Is is a harbinger of finally devendored libffi? Currently, CPython ships 1.20 (1998) while Debian LTS supplies 3.2.1 (2014).

@tiran
Copy link
Member Author

@tiran tiran commented Apr 1, 2022

libffi was de-vendored in 3.7 (Linux, BSD) and 3.8 (Windows). We only keep a copy for macos around.

@tiran tiran added the 🔨 test-with-buildbots label Apr 1, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 1, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit cc5cb24 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 1, 2022
@tiran
Copy link
Member Author

@tiran tiran commented Apr 1, 2022

ctypes tests are failing on ARM64 macOS

@tiran
Copy link
Member Author

@tiran tiran commented Apr 1, 2022

I have no clue how the SDK stuff works on macOS. In order to land the PR I would need some assistance from @ned-deily or @ronaldoussoren . Or can we drop the SDK and use system-ffi on all system?

@tiran tiran added the 🔨 test-with-buildbots label Apr 1, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 1, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 54e6b11 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 1, 2022
@ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Apr 1, 2022

I'll try to look at the PR over the weekend.

As a general statement I'd prefer to use the system install of libffi on macOS because Apple includes some magic in its version to ensure libffi closures work properly with their code signature system (in particular some magic to ensure that you don't need the "JIT" entitlement to use closures).

@tiran tiran added the 🔨 test-with-buildbots label Apr 2, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 2, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit 53607e3 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 2, 2022
@tiran tiran added the 🔨 test-with-buildbots label Apr 3, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 3, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit e4ab8cf 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 3, 2022
@tiran tiran marked this pull request as ready for review Apr 4, 2022
@tiran tiran added the 🔨 test-with-buildbots label Apr 4, 2022
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 4, 2022

🤖 New build scheduled with the buildbot fleet by @tiran for commit b626d38 🤖

If you want to schedule another build, you need to add the "🔨 test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots label Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants