bpo-47135: Accept attributes as keyword arguments in decimal.localcontext #32242
+154
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelleZijlstra
reviewed
Apr 4, 2022
|
Thank you for the review, I'll be able to make the changes later today |
JelleZijlstra
reviewed
Apr 4, 2022
Doc/library/decimal.rst
Outdated
| Raises :exc:`TypeError` if *kwargs* supplies an attribute that :class:`Context` doesn't | ||
| support. | ||
|
|
||
| .. versionchanged:: 3.11 | ||
| Raises either :exc:`TypeError` or :exc:`ValueError` if *kwargs* supplies an invalid value for an attribute. |
There was a problem hiding this comment.
There should only be one note. The note should say that keyword arguments are now supported, because that's the important part. The exceptions should stay in the main text.
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This allows attributes to be set like this
instead of like this
https://bugs.python.org/issue47135