bpo-30718: Add information about text buffering #32351
Open
+5
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methane
reviewed
Apr 7, 2022
| in bytes of a fixed-size chunk buffer. Note that specifying a buffer size this | ||
| way does not apply for files opened in text mode, where |
There was a problem hiding this comment.
"does not apply" is misleading because it is applied to underlying buffered random.
How about: "applies for binary buffered I/O, but TextIOWrapper would have another buffering."
There was a problem hiding this comment.
Hmm, for the latter part would it be possible to say instead "..., but TextIOWrapper (i.e., files opened with mode='r+') would have another buffering"? I feel that the issue was brought up as the buffering parameter is misleading for text mode, so saying TextIOWrapper alone might not be explicit enough
There was a problem hiding this comment.
'It' referring to the original suggested change or the one with mode?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
https://bugs.python.org/issue30718