bpo-40280: Detect missing threading on WASM platforms (GH-32352) #32352
+103
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
requested review from
ethanfurman,
rhettinger,
,
brettcannon,
encukou,
ericsnowcurrently,
ncoghlan,
warsaw,
vsajip and
1st1
as
code owners
tiran
changed the title
brettcannon
approved these changes
Apr 6, 2022
Co-authored-by: Brett Cannon <brett@python.org>
tiran
force-pushed
the
bpo-40280-threading-dlopen
branch
from
6050f5f
to
ee4016b
Compare
tiran
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
WASM Emscripten builds for browsers and WASI don't have pthread support. The threading API is stubbed. The changeset adds a test decorator that skips tests which required threading.
https://bugs.python.org/issue40280