fix(router): validate lazy loaded configs #45526
Conversation
Lazy loaded configs are not validated at runtime like the initial set of routes are. This change also validates lazy loaded configs right after they're loaded. BREAKING CHANGE: Lazy loaded configs are now also validated once loaded like the initial set of routes are. Lazy loaded modules which have invalid Route configs will now error. Note that this is only done in dev mode so there is no production impact of this change. Fixes angular#25431
atscott
added
comp: router
target: major
|
TGP revealed several failures that will need to be cleaned up |
atscott
added
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
merge assistance: the legacy unit test failure is unrelated. Also, you may want to merge and sync this on its own (in case there were regressions in g3 between the TGP run and now) |
|
This PR was merged into the repository by commit 96fd29c. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Lazy loaded configs are not validated at runtime like the initial set of
routes are. This change also validates lazy loaded configs right after
they're loaded.
BREAKING CHANGE: Lazy loaded configs are now also validated once loaded like the
initial set of routes are. Lazy loaded modules which have invalid Route
configs will now error. Note that this is only done in dev mode so
there is no production impact of this change.
Fixes #25431