DEV: use the only source for time shortcut options on all date pickers #16366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPrigorshnev
force-pushed
the
dev/use-the-only-source-for-time-shortcut-options-on-date-pickers
branch
11 times, most recently
from
4c0e316 to
73f2d38
Compare
AndrewPrigorshnev
force-pushed
the
dev/use-the-only-source-for-time-shortcut-options-on-date-pickers
branch
from
73f2d38 to
e767b07
Compare
martin-brennan
approved these changes
Apr 19, 2022
AndrewPrigorshnev
force-pushed
the
dev/use-the-only-source-for-time-shortcut-options-on-date-pickers
branch
from
e767b07 to
003afe7
Compare
ZogStriP
reviewed
Apr 21, 2022
|
|
||
| _date: null, | ||
| _time: null, | ||
|
|
||
| init() { | ||
| this._super(...arguments); | ||
| this.userTimezone = this.currentUser.resolvedTimezone(this.currentUser); |
There was a problem hiding this comment.
This API looks a bit weird. Why is resolvedTimezone on the currentUser object? Shouldn't it be a helper method?
There was a problem hiding this comment.
Yes, it is weird. It's not the first call, see #15749 (comment). I'll fix it in a separate PR in next days.
AndrewPrigorshnev
force-pushed
the
dev/use-the-only-source-for-time-shortcut-options-on-date-pickers
branch
from
003afe7 to
65a1f38
Compare
ZogStriP
approved these changes
Apr 21, 2022
AndrewPrigorshnev
force-pushed
the
dev/use-the-only-source-for-time-shortcut-options-on-date-pickers
branch
from
65a1f38 to
9b5e5f1
Compare
AndrewPrigorshnev
deleted the
dev/use-the-only-source-for-time-shortcut-options-on-date-pickers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, we added a new time-shortcut-picker. That picker had more customizable API than the old future-date-input and used a new builder of time shortcut options. Then we were going to switch
future-date-inputto the new options builder and make its API looks like the API oftime-shortcut-picker, which would make it much more customizable. I did that change in #12985, but that PR was closed without merging due to various reasons (PR was too big, had flaky specs and was opened just before a release and then got outdated).Now I'm doing this job again, this time in two steps to make it safer and easier to review. The steps are
future-date-inputlooks like API of thetime-shortcut-picker(this will be provided in the next PR)Note that still there is some duplication in code, I'm going to dry the code up more on the second step.
Note also that I haven't added many tests in this PR because tests that're needed for covering this change were already added before, mostly in #13836.
Also, the time shortcut options in the old set weren't timezone aware:
discourse/app/assets/javascripts/select-kit/addon/components/future-date-input-selector.js
Line 27 in cecdef8
so, probably we had some subtle timezone-related bugs which will be fixed by this PR.