Skip to content

gh-97847: Fix misplaced or duplicated function descriptions in the multiprocessing documentation #31482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 10 commits into from
Closed

gh-97847: Fix misplaced or duplicated function descriptions in the multiprocessing documentation #31482

wants to merge 10 commits into from

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Feb 21, 2022 •
edited
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 21, 2022
@geryogam geryogam changed the title Update multiprocessing.rst Improve the documentation of the multiprocessing module Feb 25, 2022
merwok
merwok reviewed Jun 14, 2022
View reviewed changes
@merwok
Copy link
Member

merwok commented Jun 14, 2022

Can you open a ticket to decribe the substantive problems to be fixed in the doc?
(Likewise for your other PRs that change more than 10 lines)

@geryogam @merwok
Update Doc/library/multiprocessing.rst
97a716d 
Co-authored-by: Éric <merwok@netwok.org>
@geryogam geryogam mentioned this pull request Oct 4, 2022
Open
@geryogam
Copy link
Contributor Author

geryogam commented Oct 4, 2022

Can you open a ticket to decribe the substantive problems to be fixed in the doc?
(Likewise for your other PRs that change more than 10 lines)

Sure: #97847.

@erlend-aasland
Copy link
Contributor

Can you open a ticket to decribe the substantive problems to be fixed in the doc?
(Likewise for your other PRs that change more than 10 lines)

Sure: #97847.

That issue describes stylistic changes to Sphinx/reST references only. However, this PR contains a load of other changes. That makes this PR very difficult to review; there is no explanation or rationale for most of the changes.

I therefore suggest closing this, together with the linked issue; it is highly unlikely to be reviewed, not to mention merged, in its current form.

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Nov 27, 2022
@geryogam geryogam changed the title Improve the documentation of the multiprocessing module gh-97847: Improve the documentation of the multiprocessing module Dec 1, 2022
@geryogam geryogam changed the title gh-97847: Improve the documentation of the multiprocessing module gh-97847: Fix misplaced or duplicated function descriptions in the multiprocessing documentation Dec 1, 2022
@geryogam
Copy link
Contributor Author

geryogam commented Dec 1, 2022

@erlend-aasland I have completely rewritten the issue as I realize it was very poorly explained.

@geryogam geryogam requested a review from merwok December 1, 2022 14:39
@arhadthedev
Copy link
Member

@erlend-aasland I have completely rewritten the issue as I realize it was very poorly explained.

ping

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Mar 6, 2023 •
edited
Loading

I cannot see that my remark of #31482 (comment) has been addressed; closing this PR.

If you want to follow up this, please open targeted PRs for each change. As have been noted multiple times on your other PRs, please avoid any stylistic or unrelated changes.

@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@merwok merwok Awaiting requested review from merwok

Assignees
No one assigned
Labels
awaiting review docs Documentation in the Doc dir skip news topic-multiprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@geryogam @merwok @erlend-aasland @arhadthedev @vstinner @hugovk @the-knights-who-say-ni @ezio-melotti @bedevere-bot