doc: mark tlsSocket.authorized as boolean property #42647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @tniessen. Please |
nodejs-github-bot
added
doc
lpinca
approved these changes
Apr 8, 2022
aduh95
reviewed
Apr 8, 2022
This is not a function and should not have a return type.
tniessen
force-pushed
the
doc-tls-authorized-is-not-a-function
branch
from
0f9204c
to
455358e
Compare
aduh95
approved these changes
Apr 9, 2022
tniessen
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/42647 ✔ Done loading data for nodejs/node/pull/42647 ----------------------------------- PR info ------------------------------------ Title doc: mark tlsSocket.authorized as boolean property (#42647) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch tniessen:doc-tls-authorized-is-not-a-function -> nodejs:master Labels tls, doc, fast-track Commits 1 - doc: mark tlsSocket.authorized as boolean property Committers 1 - Tobias Nießen PR-URL: https://github.com/nodejs/node/pull/42647 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/42647 Reviewed-By: Luigi Pinca Reviewed-By: Antoine du Hamel -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 07 Apr 2022 23:50:39 GMT ✔ Approvals: 2 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/42647#pullrequestreview-935926911 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/42647#pullrequestreview-937185969 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/2142298995 |
tniessen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a046125 |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this issue
Apr 25, 2022
This is not a function and should not have a return type. PR-URL: nodejs#42647 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This is not a function and should not have a return type according to our documentation style guide.