doc: add maintaining-webassembly.md #42660
Open
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested: |
VoltrexMaster
reviewed
Apr 8, 2022
mhdawson
reviewed
Apr 8, 2022
| is vendored into the Node.js deps in | ||
| [deps/uvwasi](https://github.com/nodejs/node/tree/master/deps/uvwasi). | ||
|
|
||
| To update the copy of uvwasi in the Node.js deps: |
There was a problem hiding this comment.
@cjihrig can you double check that the following text is correct?
marsonya
reviewed
Apr 10, 2022
|
PR to add streaming compilation: #42701 Unfortunately, the spec only allows |
|
@tniessen thanks for the PR! Any chance you can review/approve this PR too? |
Add maintaining-webassembly.md with strategy based on discussion in Next-10 mini-summit: nodejs/next-10#127 Signed-off-by: Michael Dawson <mdawson@devrus.com>
|
@tniessen thanks for the review, squashed and fixed the commit comment after pulling in your suggestions. |
|
@VoltrexMaster all of your comments should be fixed as well if you want to take another look. |
VoltrexMaster
reviewed
Apr 13, 2022
|
|
||
| Node.js gets its core WebAssembly support through V8. We don't need | ||
| to do anything specific to support this, all we have to do is keep | ||
| the version of V8 as up to date as possible. |
There was a problem hiding this comment.
Suggested change
| the version of V8 as up to date as possible. | |
| the version of V8 as up-to-date as possible. |
Based on @tniessen's suggestion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add maintaining-webassembly.md with startegy based
on discussion in Next-10 mini-summit:
nodejs/next-10#127
Signed-off-by: Michael Dawson mdawson@devrus.com