Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type commonjs to package.json #1281

Open
delvedor opened this issue Aug 12, 2020 · 1 comment
Open

Add type commonjs to package.json #1281

delvedor opened this issue Aug 12, 2020 · 1 comment
Labels
good first issue v7.x v8.x

Comments

@delvedor
Copy link
Member

@delvedor delvedor commented Aug 12, 2020

As suggested in the ESM guidelines of Node.js it would be good to explicit the type of the module.

{
+  "type": "commonjs",
}
@delvedor delvedor added v7.x v8.x good first issue labels Aug 12, 2020
@RinkiyaKeDad
Copy link

@RinkiyaKeDad RinkiyaKeDad commented Sep 16, 2020

Hi! I'm new to elastic search and will like to work on this issue. Could you point me in the right direction? As far as I understand I need to add this line in the package.json right?

@RinkiyaKeDad RinkiyaKeDad mentioned this issue Sep 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue v7.x v8.x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@delvedor @RinkiyaKeDad