fix #255: Add new rule require-v-if-else-key #1845
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doug-wade
commented
Apr 13, 2022
FloEdelmann
requested changes
Apr 13, 2022
ota-meshi
requested changes
Apr 14, 2022
Co-authored-by: Flo Edelmann <florian-edelmann@online.de>
FloEdelmann
approved these changes
Apr 16, 2022
ota-meshi
reviewed
Apr 16, 2022
| </template> | ||
| </div> | ||
| </template> | ||
| ` |
There was a problem hiding this comment.
Why is this valid? I think this should be reported.
There was a problem hiding this comment.
I must have misinterpreted your comment:
Note that vue2 does not allow you to place a key in .
If no keys are allowed, mustn't we allow templates without keys?
There was a problem hiding this comment.
In Vue2 need to put the key on the actual element, not the <template>.
e.g.
<template v-if="foo">
<div key="a" />
</template>
<template v-else>
<div key="b" />
</template><template v-if="foo">
<div key="a" />
<div key="b" />
</template>
<template v-else>
<div key="c" />
<div key="d" />
</template>However, with Vue3 you can do the following:
<template v-if="foo" key="a">
<div />
</template>
<template v-else key="b">
<div />
</template><template v-if="foo" key="a">
<div />
<div />
</template>
<template v-else key="b">
<div />
<div />
</template>
|
Heya, things have gotten pretty busy for me, and I don't think I'll have time to clean this one up in the near future. I'm going to close this one for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one's probably a smidge later than it could have been -- I can't find it in the style guide anymore -- but better late than never?