Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-84461: Drop -sWASM, fix building tests for browser (GH-91530) #91530

Merged
merged 1 commit into from Apr 14, 2022

Conversation

Copy link
Member

@tiran tiran commented Apr 14, 2022

  • drop unnecessary =1 suffix from Emscripten flags
  • drop unnecessary -sWASM flag for side modules
  • rename build_platform to build_wasm. I introduced the target
    for WASM builds a couple of months ago.
  • fix --enable-test-modules for browser builds

@tiran tiran changed the title bpo-40280: Drop -sWASM, fix building tests for browser gh-8446: Drop -sWASM, fix building tests for browser Apr 14, 2022
@tiran tiran changed the title gh-8446: Drop -sWASM, fix building tests for browser gh-84461: Drop -sWASM, fix building tests for browser Apr 14, 2022
- drop unnecessary ``=1`` suffix from Emscripten flags
- drop unnecessary ``-sWASM`` flag for side modules
- rename ``build_platform`` to ``build_wasm``. I introduced the target
  for WASM builds a couple of months ago.
- fix ``--enable-test-modules`` for browser builds
@tiran tiran force-pushed the bpo-40280-dynamic-tests branch from b0b718c to 59ba500 Compare Apr 14, 2022
@tiran tiran changed the title gh-84461: Drop -sWASM, fix building tests for browser gh-84461: Drop -sWASM, fix building tests for browser (GH-91530) Apr 14, 2022
@tiran tiran merged commit 7acedd7 into python:main Apr 14, 2022
12 checks passed
@tiran tiran deleted the bpo-40280-dynamic-tests branch Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants