Skip to content

clarify precondition to working with wiki locally #16468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 13, 2022
Merged

clarify precondition to working with wiki locally #16468

merged 3 commits into from
May 13, 2022

Conversation

zachvalenta
Copy link
Contributor

Docs didn't mention that you need to add initial wiki page via Github before working with wiki files locally.

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

@zachvalenta
clarify precondition to working with wiki locally
dd3a451 
Docs didn't mention that you need to add initial wiki page via Github before working with wiki files locally.
@welcome
Copy link

welcome bot commented Mar 22, 2022

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Mar 22, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Mar 22, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
communities/documenting-your-project-with-wikis/adding-or-editing-wiki-pages.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@ramyaparimi ramyaparimi added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review communities Content related to Communities and removed triage Do not begin working on this issue until triaged by the team labels Mar 23, 2022
@ramyaparimi
Copy link
Contributor

@zachvalenta
Thanks so much for opening a PR! I'll get this triaged for review ⚡

@S5-CHRIS

This comment was marked as spam.

Sign in to view
@S5-CHRIS

This comment was marked as spam.

Sign in to view
@S5-CHRIS

This comment was marked as spam.

Sign in to view
@Th1983

This comment was marked as spam.

Sign in to view
guntrip
guntrip approved these changes May 13, 2022
View reviewed changes
Copy link
Contributor

@guntrip guntrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for opening this, @zachvalenta! ✨ I think this will really help people.

I've made one small change and removed the link to Stack Overflow; I don't think the link added much context and it's one more thing to 404 in the future 😄

I'll get this ready to merge. Thanks so much for contributing to our docs!

@guntrip guntrip enabled auto-merge (squash) May 13, 2022 07:54
@guntrip guntrip merged commit a2d9aea into github:main May 13, 2022
@github-actions
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guntrip guntrip guntrip approved these changes

Assignees
No one assigned
Labels
communities Content related to Communities content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zachvalenta @ramyaparimi @S5-CHRIS @Th1983 @guntrip