Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable JobTrackingWithFinalizers due to unresolved bug #109487

Merged
merged 1 commit into from Apr 15, 2022
Merged

Disable JobTrackingWithFinalizers due to unresolved bug #109487

merged 1 commit into from Apr 15, 2022
+2 −2

Conversation

alculquicondor
Copy link
Member

@alculquicondor alculquicondor commented Apr 14, 2022 •
edited

What type of PR is this?

/kind bug
/kind regression

What this PR does / why we need it:

Disable JobTrackingWithFinalizers due to unresolved bug

Which issue(s) this PR fixes:

Mitigates #109485

Special notes for your reviewer:

There are no E2E changes required, because they are independent of the feature.

Does this PR introduce a user-facing change?

Sets JobTrackingWithFinalizers, beta feature, as disabled by default, due to unresolved bug https://github.com/kubernetes/kubernetes/issues/109485

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress release-note size/XS kind/bug kind/regression cncf-cla: yes do-not-merge/needs-sig labels Apr 14, 2022
@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Apr 14, 2022

@alculquicondor: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage needs-priority labels Apr 14, 2022
@k8s-ci-robot k8s-ci-robot requested review from dchen1107 and lavalamp Apr 14, 2022
@alculquicondor
Copy link
Member Author

@alculquicondor alculquicondor commented Apr 14, 2022

The failure looks like #109473

@k8s-ci-robot k8s-ci-robot added area/test sig/testing and removed do-not-merge/needs-sig labels Apr 14, 2022
@alculquicondor
Copy link
Member Author

@alculquicondor alculquicondor commented Apr 14, 2022

/sig apps
/area batch

@k8s-ci-robot k8s-ci-robot added sig/apps area/batch labels Apr 14, 2022
@alculquicondor
Copy link
Member Author

@alculquicondor alculquicondor commented Apr 14, 2022

/retest

@alculquicondor
Copy link
Member Author

@alculquicondor alculquicondor commented Apr 14, 2022

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added priority/critical-urgent and removed needs-priority labels Apr 14, 2022
@alculquicondor alculquicondor changed the title WIP Disable JobTrackingWithFinalizers due to unresolved bug Disable JobTrackingWithFinalizers due to unresolved bug Apr 14, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress label Apr 14, 2022
liggitt
liggitt reviewed Apr 14, 2022
View changes
test/integration/job/job_test.go Outdated Show resolved Hide resolved
@alculquicondor
Disable JobTrackingWithFinalizers due to unresolved bug
3b18613 
Change-Id: Ieeeab689ae51dfe0dc06bdca88519d0ecf66d636
@liggitt
Copy link
Member

@liggitt liggitt commented Apr 14, 2022

/lgtm
/approve
/milestone v1.24

This will be picked to release-1.23 to mitigate a regression in that release. If this isn't included in 1.24.0, we'd pick it to 1.24.1. I think it is clearer/cleaner to include in 1.24.0 (we're still in the window where regressions identified in release candidates would be fixed), but will defer to the release team.

/hold for release team ack

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold label Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.24 milestone Apr 14, 2022
@k8s-ci-robot k8s-ci-robot added lgtm approved labels Apr 14, 2022
@alculquicondor alculquicondor mentioned this pull request Apr 14, 2022
Open
@cici37
Copy link
Contributor

@cici37 cici37 commented Apr 14, 2022

Does doc need to be updated as well: content/en/docs/concepts/workloads/controllers/job.md ?
/cc @nate-double-u

@k8s-ci-robot k8s-ci-robot requested a review from nate-double-u Apr 14, 2022
@nate-double-u nate-double-u mentioned this pull request Apr 15, 2022
Open
@nate-double-u
Copy link

@nate-double-u nate-double-u commented Apr 15, 2022

Does doc need to be updated as well: content/en/docs/concepts/workloads/controllers/job.md?

I think so, I've opened a k/website issue here: kubernetes/website#32944

Thanks for the heads up @cici37!

soltysh
soltysh approved these changes Apr 15, 2022
View changes
Copy link
Contributor

@soltysh soltysh left a comment

/lgtm
/approve
and 👍 for 1.24 inclusion from sig-apps pov

@k8s-ci-robot
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot commented Apr 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, liggitt, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt
Copy link
Member

@liggitt liggitt commented Apr 15, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold label Apr 15, 2022
@k8s-ci-robot k8s-ci-robot merged commit a750d80 into kubernetes:master Apr 15, 2022
16 checks passed
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 15, 2022
Open
@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liggitt liggitt

@soltysh soltysh

@dchen1107 dchen1107

@lavalamp lavalamp

@nate-double-u nate-double-u

Assignees

@soltysh soltysh

@liggitt liggitt

Labels
approved area/batch area/test cncf-cla: yes kind/bug kind/regression lgtm needs-triage priority/critical-urgent release-note sig/apps sig/testing size/XS
Projects
None yet
Milestone
v1.24
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@alculquicondor @k8s-ci-robot @liggitt @cici37 @nate-double-u @soltysh