Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" #91667

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Apr 18, 2022

Reverts #32087

See #91260

@bedevere-bot bedevere-bot added tests awaiting review labels Apr 18, 2022
@kumaraditya303 kumaraditya303 changed the title Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" [3.10] Revert "[3.10] bpo-47104: Rewrite asyncio.to_thread tests to use IsolatedAsyncioTestCase (GH-32086)" Apr 18, 2022
@kumaraditya303 kumaraditya303 requested a review from pablogsal Apr 18, 2022
@gpshead
Copy link
Member

@gpshead gpshead commented Apr 19, 2022

I have a couple ideas regarding #91676, let's hold off on submitting this for at least another day to see if I can fix the actual cause behind this.

workaround today for those CI fails and blocks merge on: click the rerun failed button. usually you'll get a good blocking ubuntu run within a couple of retries. (macos isn't blocking)

@kumaraditya303
Copy link
Contributor Author

@kumaraditya303 kumaraditya303 commented Apr 19, 2022

Superseded by #91680

@kumaraditya303 kumaraditya303 deleted the revert-32087-backport-ff619c7-3.10 branch Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants