Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement to Lifecycle of a Pull Request at git push origin #780

Open
MaxwellDupre opened this issue Dec 23, 2021 · 2 comments
Open

Improvement to Lifecycle of a Pull Request at git push origin #780

MaxwellDupre opened this issue Dec 23, 2021 · 2 comments

Comments

@MaxwellDupre
Copy link

@MaxwellDupre MaxwellDupre commented Dec 23, 2021

Where:

When all of your changes are committed (i.e. git status doesn’t list anything), you will want to push your branch to your fork:

git push origin <branch name>

This will get your changes up to GitHub.

There is a step missing which gave me some issue. That is the bit about the git command responds with username and password. If you enter your GitHub password the response is:

Username for 'https://github.com':
Password for 'https://@github.com':
remote: Support for password authentication was removed on August 13, 2021. Please use a personal access token instead.
remote: Please see https://github.blog/2020-12-15-token-authentication-requirements-for-git-operations/ for more information.
fatal: Authentication failed for 'https://github.com//cpython.git/'

So I suggest adding enough info to get the beginners around this such that the page now reads:

Ensure that you have created a personal access token link.
Note that you will likely need the token until your changes have been accepted.
When all of your changes are committed (i.e. git status doesn’t list anything), you will want to push your branch to your fork:

git push origin <branch name>

At the password prompt:
Password for 'https://@github.com':

Enter you personal access token (ghp_1e3f...) instead of your usual GitHub password.
This will get your changes up to GitHub.

@methane
Copy link
Member

@methane methane commented Dec 24, 2021

I don't want to recommend to create PAT manually. Users can use SSH, CredentialManager, or create PAT automatically with gh auth login too.

I prefer just adding a link to this section.
https://docs.github.com/ja/authentication/keeping-your-account-and-data-secure/about-authentication-to-github#authenticating-with-the-command-line

@MaxwellDupre
Copy link
Author

@MaxwellDupre MaxwellDupre commented Dec 24, 2021

Hi,
That's fine as long as others don't fall into the pit that I did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants