Prevent copying of venv folder in the Docker image #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have not used Docker, so I cannot provide a meaningful review. Perhaps @cblument can take a look? |
|
Suggestion: Setup auto build on docker hub. Another (better) option would be to create an organization on Docker Hub as well. |
|
This is safe to merge |
paulodiovani
approved these changes
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
After diving into the current image I noticed that the
venvwas copied in there. This PR should prevent that from happing in future builds.What has been done:
Notes:
RUN /sbin/apk add tor. Is this supposed to be there? Maybe we can rebuild the image to reflect the Dockerfile in the repository.