Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fish path setup on macOS #91629

Closed
drewcassidy opened this issue Apr 17, 2022 · 1 comment
Closed

Improve Fish path setup on macOS #91629

drewcassidy opened this issue Apr 17, 2022 · 1 comment
Assignees
Labels
OS-mac topic-installation type-feature A feature request or enhancement

Comments

@drewcassidy
Copy link
Contributor

drewcassidy commented Apr 17, 2022

Feature or enhancement

Improve the path setup on macOS for users of the Fish shell

Pitch

Right now, the installer sets up python paths the same way as on every other shell: by appending a line to the end of the config file that adds directly to $PATH. Modifying the users config directly is not the best way to do this in fish, which has a conf.d directory to place configs into instead. In addition, fish has the fish_add_path function that doesn't allow duplicate entries in the PATH which can get out of hand when re-sourcing the config file multiple times.

I am working on a PR to address this right now, by writing a file for each python install to conf.d which adds the path using fish_add_path

Linked PRs

@drewcassidy drewcassidy added the type-feature A feature request or enhancement label Apr 17, 2022
@ned-deily ned-deily self-assigned this Apr 17, 2022
ned-deily pushed a commit that referenced this issue Apr 21, 2024
…stalling for the Fish shell. (GH-91630)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@ned-deily
Copy link
Member

Thanks for the PR and your patience. Merged for 3.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS-mac topic-installation type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

4 participants