Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JDK 19 #10001

Merged
merged 2 commits into from Apr 21, 2022
Merged

Support JDK 19 #10001

merged 2 commits into from Apr 21, 2022
+23 −18

Conversation

Philippus
Copy link
Member

@Philippus Philippus commented Apr 13, 2022 •
edited

Applying this PR will:

  • make -target support JDK 19
  • upgrade to ASM 9.3, for JDK 19 support in optimizer
  • add a test for -target:jvm-7

modeled after #9489. Fixes scala/bug#12570 for scala 2.13.x.
2.12.x PR is #10000

I think there's first some work to be done in https://github.com/scala/scala-asm.

@scala-jenkins scala-jenkins added this to the 2.13.9 milestone Apr 13, 2022
This was referenced Apr 13, 2022
Merged
Merged
@SethTisue SethTisue marked this pull request as draft Apr 13, 2022
@SethTisue SethTisue self-assigned this Apr 13, 2022
@lrytz
Copy link
Member

lrytz commented Apr 21, 2022

Published scala-asm 9.3.0-scala-1. The build fails with

[error] did you mean V10, V11, V12, or V13?
[error]     case "19" => asm.Opcodes.v19
[error]                              ^

@Philippus
Copy link
Member Author

Philippus commented Apr 21, 2022

That should be a V instead of a v, I'll fix it.

@lrytz lrytz marked this pull request as ready for review Apr 21, 2022
@lrytz lrytz requested a review from SethTisue Apr 21, 2022
@SethTisue SethTisue added the release-notes worth highlighting in next release notes label Apr 21, 2022
@SethTisue SethTisue merged commit 79a7324 into scala:2.13.x Apr 21, 2022
4 checks passed
@Philippus Philippus deleted the issue-12570-scala213 branch Apr 21, 2022
@som-snytt
Copy link
Contributor

som-snytt commented Apr 22, 2022 •
edited

There will be have been conflicts with #9982

@SethTisue SethTisue changed the title Support JDK19 Support JDK 19 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue

Assignees

@SethTisue SethTisue

Labels
release-notes worth highlighting in next release notes
Milestone
2.13.9
5 participants
@Philippus @lrytz @som-snytt @SethTisue @scala-jenkins