Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Windows builds since 2020.05.28 #158

Closed
vsemozhetbyt opened this issue May 31, 2020 · 8 comments
Closed

No Windows builds since 2020.05.28 #158

vsemozhetbyt opened this issue May 31, 2020 · 8 comments

Comments

@bzoz
Copy link

@bzoz bzoz commented Jun 1, 2020

Maybe it is because the build issues in nodejs/node#33579?

@gengjiawen
Copy link

@gengjiawen gengjiawen commented Jun 1, 2020

Maybe it is because the build issues in nodejs/node#33579?

Is it the node-v8 daily windows build using vs2017 ? @targos @ryzokuken

@gengjiawen
Copy link

@gengjiawen gengjiawen commented Jun 1, 2020

Looks like windows build is broken: https://github.com/nodejs/node-v8/runs/726470134.

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1757,1): error C2027: use of undefined type 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\execution\off-thread-isolate.h(20): message : see declaration of 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1756): message : while compiling class template member function 'void std::default_delete<v8::internal::OffThreadTransferHandleStorage>::operator ()(_Ty *) noexcept const' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
          with
          [
              _Ty=v8::internal::OffThreadTransferHandleStorage
          ]

@gengjiawen
Copy link

@gengjiawen gengjiawen commented Jun 1, 2020

Looks like windows build is broken: nodejs/node-v8/runs/726470134.

C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1757,1): error C2027: use of undefined type 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
D:\a\node-v8\node-v8\deps\v8\src\execution\off-thread-isolate.h(20): message : see declaration of 'v8::internal::OffThreadTransferHandleStorage' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Tools\MSVC\14.25.28610\include\memory(1756): message : while compiling class template member function 'void std::default_delete<v8::internal::OffThreadTransferHandleStorage>::operator ()(_Ty *) noexcept const' [D:\a\node-v8\node-v8\tools\v8_gypfiles\v8_init.vcxproj]
          with
          [
              _Ty=v8::internal::OffThreadTransferHandleStorage
          ]

Not sure related to this:
nodejs/node#33685
v8/v8@e87972b#commitcomment-39582496.

@gengjiawen
Copy link

@gengjiawen gengjiawen commented Jun 1, 2020

Possible fix: #159

@gengjiawen
Copy link

@gengjiawen gengjiawen commented Jun 2, 2020

Possible fix: #159

Looks like build passed on github action.

Upstream patch: https://chromium-review.googlesource.com/c/v8/v8/+/2226121.

@gengjiawen
Copy link

@gengjiawen gengjiawen commented Jun 3, 2020

Looks like fixed: https://nodejs.org/download/v8-canary/v15.0.0-v8-canary20200603908772e6f4/

@gengjiawen gengjiawen closed this Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants