Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mmap module: add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD constants #81652

Closed
devnexen mannequin opened this issue Jul 1, 2019 · 6 comments
Closed

mmap module: add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD constants #81652

devnexen mannequin opened this issue Jul 1, 2019 · 6 comments
Assignees
@corona10 @yeojin-dev
Labels
easy extension-modules C modules in the Modules dir OS-freebsd type-feature A feature request or enhancement

Comments

@devnexen
Copy link
Mannequin

devnexen mannequin commented Jul 1, 2019 •
edited by bedevere-bot

BPO 37471
Nosy @vstinner, @koobs, @devnexen
PRs
  • bpo-37471: mmap module adding FreeBSD specific flag into the constants #14513
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2019-07-01.14:22:37.149>
labels = ['extension-modules', 'type-feature', '3.9']
title = 'mmap module: add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD constants'
updated_at = <Date 2019-07-08.13:58:54.452>
user = 'https://github.com/devnexen'

    bugs.python.org fields:

    activity = <Date 2019-07-08.13:58:54.452>
actor = 'devnexen'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Extension Modules', 'FreeBSD']
creation = <Date 2019-07-01.14:22:37.149>
creator = 'devnexen'
dependencies = []
files = []
hgrepos = []
issue_num = 37471
keywords = []
message_count = 3.0
messages = ['347023', '347026', '347027']
nosy_count = 3.0
nosy_names = ['vstinner', 'koobs', 'devnexen']
pr_nums = ['14513']
priority = 'normal'
resolution = None
stage = None
status = 'open'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue37471'
versions = ['Python 3.9']

    Linked PRs
    @devnexen devnexen mannequin added 3.9 extension-modules C modules in the Modules dir labels Jul 1, 2019
    @koobs
    Copy link

    koobs commented Jul 1, 2019

    Thanks David!

    Can this be backported to earlier 3.x's and 2.7?

    @koobs koobs changed the title mmap module, adding new constant mmap module, add MAP_ALIGNED_SUPER FreeBSD constant Jul 1, 2019
    @vstinner
    Copy link
    Member

    vstinner commented Jul 1, 2019

    Can this be backported to earlier 3.x's and 2.7?

    No, a new constant is a new feature. If we add it to Python 3.7.4, it would mean that an application written with 3.7.4 will fail on 3.7.3 which would be surprising and bad.

    @vstinner vstinner changed the title mmap module, add MAP_ALIGNED_SUPER FreeBSD constant mmap module: add MAP_ALIGNED_SUPER FreeBSD constant Jul 1, 2019
    @vstinner vstinner added the type-feature A feature request or enhancement label Jul 1, 2019
    @koobs
    Copy link

    koobs commented Jul 1, 2019

    Thanks for clarifying Victor

    @devnexen devnexen mannequin changed the title mmap module: add MAP_ALIGNED_SUPER FreeBSD constant mmap module: add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD constants Jul 8, 2019
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland added easy and removed 3.9 labels May 18, 2022
    @corona10 corona10 self-assigned this Feb 17, 2023
    @corona10
    Copy link
    Member

    @vstinner @erlend-aasland
    As I shared, I will go ahead with this issue as the internal OSS sprint.
    I will delegate the issue to my mentee as the good first issue.

    @yeojin-dev
    Copy link
    Contributor

    I'm looking this issue. 👀

    @bedevere-bot bedevere-bot mentioned this issue Feb 23, 2023
    Merged
    corona10 pushed a commit that referenced this issue Feb 24, 2023
    @yeojin-dev
    gh-81652: Add MAP_ALIGNED_SUPER FreeBSD and MAP_CONCEAL OpenBSD const…
    347f740 
    …ants (gh-102191)
    @corona10
    Copy link
    Member

    Thank you @yeojin-dev :)

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees

    @corona10 corona10

    @yeojin-dev yeojin-dev

    Labels
    easy extension-modules C modules in the Modules dir OS-freebsd type-feature A feature request or enhancement
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    5 participants
    @vstinner @koobs @corona10 @erlend-aasland @yeojin-dev