Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate modules listed in PEP 594 #91217

Open
brettcannon opened this issue Mar 18, 2022 · 10 comments
Open

Deprecate modules listed in PEP 594 #91217

brettcannon opened this issue Mar 18, 2022 · 10 comments
Assignees
Labels
3.11 deferred-blocker stdlib

Comments

@brettcannon
Copy link
Member

@brettcannon brettcannon commented Mar 18, 2022

BPO 47061
Nosy @warsaw, @brettcannon, @hugovk, @miss-islington, @tirkarthi
PRs
  • #31984
  • #32039
  • #32082
  • #32134
  • #32350
  • #32392
  • #32410
  • Dependencies
  • bpo-47022: PEP 594: Document removal of asynchat, asyncore and smtpd
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/brettcannon'
    closed_at = None
    created_at = <Date 2022-03-18.19:46:10.638>
    labels = ['deferred-blocker', 'library', '3.11']
    title = 'Deprecate modules listed in PEP 594'
    updated_at = <Date 2022-04-08.03:39:21.812>
    user = 'https://github.com/brettcannon'

    bugs.python.org fields:

    activity = <Date 2022-04-08.03:39:21.812>
    actor = 'brett.cannon'
    assignee = 'brett.cannon'
    closed = False
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2022-03-18.19:46:10.638>
    creator = 'brett.cannon'
    dependencies = ['47022']
    files = []
    hgrepos = []
    issue_num = 47061
    keywords = ['patch']
    message_count = 8.0
    messages = ['415521', '415525', '415725', '415732', '415733', '415906', '416804', '416896']
    nosy_count = 5.0
    nosy_names = ['barry', 'brett.cannon', 'hugovk', 'miss-islington', 'xtreak']
    pr_nums = ['31984', '32039', '32082', '32134', '32350', '32392', '32410']
    priority = 'deferred blocker'
    resolution = None
    stage = 'patch review'
    status = 'open'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue47061'
    versions = ['Python 3.11']

    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Mar 18, 2022

    https://peps.python.org/pep-0594/

    The SC has asked that all modules deprecated by PEP-594 have the documented deprecation backported. The message should also not have any specific removal version to avoid any potential delay, but then making the bugfix-only docs incorrect.

    @brettcannon brettcannon self-assigned this Mar 18, 2022
    @brettcannon brettcannon added the stdlib label Mar 18, 2022
    @brettcannon brettcannon changed the title Document PEP 594 deprecations Deprecate modules listed in PEP 594 Mar 18, 2022
    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Mar 18, 2022

    The first PR for documenting the modules is up. Once this gets merged and backported I will add a helper function in warnings and then make the appropriate code changes.

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Mar 21, 2022

    New changeset 9ac2de9 by Brett Cannon in branch 'main':
    bpo-47061: document module deprecations due to PEP-594 (GH-31984)
    9ac2de9

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Mar 22, 2022

    New changeset c353835 by Miss Islington (bot) in branch '3.10':
    [3.10] bpo-47061: document module deprecations due to PEP-594 (GH-31984) (GH-32039)
    c353835

    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Mar 22, 2022

    One thing I forgot to mention is that I will be updating What's New as the code deprecations land.

    @miss-islington
    Copy link
    Contributor

    @miss-islington miss-islington commented Mar 23, 2022

    New changeset e513b81 by Hugo van Kemenade in branch '3.9':
    [3.9] bpo-47061: document module deprecations due to PEP-594 (GH-31984) (GH-32082)
    e513b81

    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Apr 5, 2022

    New changeset c1d93b6 by Brett Cannon in branch 'main':
    bpo-47061: deprecate the aifc module (GH-32134)
    c1d93b6

    @brettcannon
    Copy link
    Member Author

    @brettcannon brettcannon commented Apr 6, 2022

    New changeset 32b3387 by Brett Cannon in branch 'main':
    bpo-47061: use warnings._deprecated() with asynchat, asyncore, and smtpd (GH-32350)
    32b3387

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    warsaw added a commit that referenced this issue Apr 13, 2022
    * Deprecate imghdr
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    
    * Update Doc/whatsnew/3.11.rst
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    
    * Inline `imghdr` into `email.mime.image`
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    Co-authored-by: Barry Warsaw <barry@python.org>
    gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Apr 13, 2022
    gvanrossum pushed a commit to gvanrossum/cpython that referenced this issue Apr 13, 2022
    * Deprecate imghdr
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    
    * Update Doc/whatsnew/3.11.rst
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    
    * Inline `imghdr` into `email.mime.image`
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    Co-authored-by: Barry Warsaw <barry@python.org>
    miss-islington pushed a commit that referenced this issue Apr 16, 2022
    Automerge-Triggered-By: GH:brettcannon
    miss-islington pushed a commit that referenced this issue Apr 17, 2022
    Automerge-Triggered-By: GH:brettcannon
    brettcannon added a commit that referenced this issue Apr 22, 2022
    Also inline necessary functionality from `sndhdr` into `email.mime.audio` for `MIMEAudio`.
    
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    brettcannon added a commit that referenced this issue Apr 23, 2022
    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    3.11 deferred-blocker stdlib
    Projects
    Status: Deferred Blocker
    Development

    No branches or pull requests

    2 participants