Skip to content

bpo-36388: fix Pdb.do_debug to not trace itself #23202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bpo-36388: fix Pdb.do_debug to not trace itself #23202

wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Nov 9, 2020 •
edited by bedevere-bot
Loading

blueyed added a commit to blueyed/pdbpp that referenced this pull request Nov 9, 2020
@blueyed
Fix debug with no previous tracing (e.g. in post mortem)
8c4679d 
This adopts `Pdb.do_debug`, given there are fixes in there already, and
it is not trivial to "patch out" the wrong `sys.settrace` in there
easily.

Ref: https://bugs.python.org/issue36388
Ref: python/cpython#23202
blueyed added a commit to blueyed/pdbpp that referenced this pull request Nov 9, 2020
@blueyed
Fix debug with no previous tracing (e.g. in post mortem)
8f8087f 
This adopts `Pdb.do_debug`, given there are fixes in there already, and
it is not trivial to "patch out" the wrong `sys.settrace` in there
easily.

Ref: https://bugs.python.org/issue36388
Ref: python/cpython#23202
@blueyed blueyed mentioned this pull request Nov 9, 2020
Merged
blueyed added a commit to blueyed/pdbpp that referenced this pull request Nov 13, 2020
@blueyed
Fix debug with no previous tracing (e.g. in post mortem)
7e335d1 
This adopts `Pdb.do_debug`, given there are fixes in there already, and
it is not trivial to "patch out" the wrong `sys.settrace` in there
easily.

Ref: https://bugs.python.org/issue36388
Ref: python/cpython#23202
blueyed added a commit to pdbpp/pdbpp that referenced this pull request Nov 14, 2020
@blueyed
Fix debug with no previous tracing (e.g. in post mortem) (#425)
dd633bb 
This adopts `Pdb.do_debug`, given there are fixes in there already, and
it is not trivial to "patch out" the wrong `sys.settrace` in there
easily.

Ref: https://bugs.python.org/issue36388
Ref: python/cpython#23202
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@blueyed
Copy link
Contributor Author

blueyed commented Dec 16, 2020

This is still legit, but only missing review and a test.
It's used in pdp++, where it has a test that could be adopted: pdbpp/pdbpp@dd633bb#diff-b95fdb555737b59555993f2928802c507ba6b466dd9de0f8bafa256c1cce52d2R5992-R6013

asvetlov
asvetlov requested changes Dec 16, 2020
View reviewed changes
Copy link
Contributor

@asvetlov asvetlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good.
NEWS entry and tests are needed.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@AlexWaygood
Copy link
Member

AlexWaygood commented Apr 19, 2022 •
edited
Loading

Ping, @blueyed -- is this still something you're interested in working on? :)

@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Jul 31, 2022
@kumaraditya303
Copy link
Contributor

Closing as it is stale, if you want to work on this, the PR can be re-opened or a new PR can be created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@blueyed @bedevere-bot @AlexWaygood @kumaraditya303 @asvetlov @the-knights-who-say-ni @ezio-melotti