Skip to content

bpo-42443 Add Thread Creation Hook to Threading.py #23477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

bpo-42443 Add Thread Creation Hook to Threading.py #23477

wants to merge 6 commits into from

Conversation

qstanczyk
Copy link

@qstanczyk qstanczyk commented Nov 23, 2020 •
edited by gpshead
Loading

This is implementation for https://bugs.python.org/issue42443

#86609

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@qstanczyk

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@gpshead
Copy link
Member

gpshead commented Nov 23, 2020

A unittest in Lib/test/test_threading.py that confirms the new APIs work is needed.

@gpshead gpshead self-assigned this Nov 23, 2020
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Dec 25, 2020
@gpshead
Copy link
Member

gpshead commented May 20, 2021 •
edited
Loading

I made a variety of edits as noted in the bug. Still TODO:

  • A Lib/test/test_threading.py unittest.
  • Doc/library/threading.rst documentation.
  • A NEWS blurb.

MaxwellDupre
MaxwellDupre suggested changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@MaxwellDupre MaxwellDupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you complete your TODO list or submit at a later date?

@gpshead
Copy link
Member

gpshead commented Apr 20, 2022

Can you complete your TODO list or submit at a later date?

All of those TODO list items are requirements before this can be merged.

@qstanczyk qstanczyk mannequin mentioned this pull request Apr 20, 2022
Open
@github-actions github-actions bot removed the stale Stale PR or inactive for long period of time. label Aug 1, 2022
@gpshead gpshead added stale Stale PR or inactive for long period of time. awaiting changes and removed awaiting core review labels May 20, 2023
@gpshead gpshead removed their assignment May 20, 2023
@python-cla-bot
Copy link

The following commit authors need to sign the Contributor License Agreement:

CLA signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxwellDupre MaxwellDupre MaxwellDupre requested changes

Assignees
No one assigned
Labels
awaiting changes stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@qstanczyk @the-knights-who-say-ni @gpshead @MaxwellDupre @ezio-melotti @bedevere-bot