bpo-47075: Add shutdown_timeout to multiprocessing BaseManager #32112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think that having two separated timeout parameters, one for wait() and a second for join(), is needed. I prefer to have a single value. The process should be able to handle the |
|
@pitrou: Would you mind reviewing the updated PR? I completed the doc and changed the behavior: kill the process if it is still alive shutdown_timeout seconds after being terminated. |
gpshead
approved these changes
Apr 15, 2022
Add an optional keyword 'shutdown_timeout' parameter to the multiprocessing.BaseManager constructor. Kill the process if terminate() takes longer than the timeout. Multiprocessing tests pass test.support.SHORT_TIMEOUT to BaseManager.shutdown_timeout.
JelleZijlstra
added a commit
to python/typeshed
that referenced
this pull request
Apr 26, 2022
AlexWaygood
pushed a commit
to python/typeshed
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Add an optional keyword 'shutdown_timeout' parameter to the
multiprocessing.BaseManager constructor.
Multiprocessing tests pass test.support.SHORT_TIMEOUT
to BaseManager.shutdown_timeout.
https://bugs.python.org/issue47075