gh-91061: also accept pathlib.Path for winsound.PlaySound #91489
+12
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
While the autolinker bot is being enhanced, here is a link so the readers of the PR can jump here via an autogenerated line back there: gh-91061. |
barneygale
reviewed
Apr 19, 2022
| PyErr_Format(PyExc_TypeError, | ||
| "'sound' must be str or None, not '%s'", | ||
| "'sound' must be str, pathlib.Path, or None; not '%s'", |
There was a problem hiding this comment.
I think this should say os.PathLike rather than pathlib.Path. Per the docs for PyOS_FSPath():
If the object implements the
os.PathLikeinterface, then__fspath__()is returned as long as it is astrorbytesobject.
Also affects the NEWS entry.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.