Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-89885: Add example for spam.Bar #91523

Merged
merged 4 commits into from Apr 17, 2022
Merged

gh-89885: Add example for spam.Bar #91523

merged 4 commits into from Apr 17, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Apr 14, 2022

#89885

Instead of showing foo and Foo, I opted to change it slightly and show foo and Bar (deleting bar)

@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir labels Apr 14, 2022
@JelleZijlstra
Copy link
Member

JelleZijlstra commented Apr 15, 2022

What if we got rid of bar completely? I think one submodule is enough to make the point, and examples should be as simple as possible.

@slateny
Copy link
Contributor Author

slateny commented Apr 15, 2022

Hmm, I agree that examples should be as simple as possible, but for some reason I feel like having more than one makes somewhat of a stronger point, maybe similar to how examples with lists usually seem to come with multiple elements, even though it might not be strictly necessary.

I'll mull over it a bit, but I can't quite put my finger on a concrete reason so I'll probably get it changed to the simpler example

JelleZijlstra
JelleZijlstra reviewed Apr 16, 2022
View changes
Doc/reference/import.rst Outdated Show resolved Hide resolved
Doc/reference/import.rst Outdated Show resolved Hide resolved
Doc/reference/import.rst Outdated Show resolved Hide resolved
@slateny @JelleZijlstra
Apply suggestions from code review
566c8b3 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@JelleZijlstra JelleZijlstra self-assigned this Apr 16, 2022
@JelleZijlstra JelleZijlstra merged commit d5a6957 into python:main Apr 17, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 17, 2022

Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2022
@slateny @miss-islington
pythongh-89885: Improve import example in language reference (pythonG…
24c620b 
…H-91523)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5a6957)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2022

GH-91648 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 17, 2022
@slateny @miss-islington
pythongh-89885: Improve import example in language reference (pythonG…
46281e6 
…H-91523)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5a6957)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 17, 2022

GH-91649 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Apr 17, 2022
@miss-islington @slateny
gh-89885: Improve import example in language reference (GH-91523)
531f66a 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5a6957)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
JelleZijlstra pushed a commit that referenced this pull request Apr 17, 2022
@miss-islington @slateny
gh-89885: Improve import example in language reference (GH-91523) (#9…
3537d89 
…1649)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5a6957)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@slateny slateny deleted the s/ref branch Apr 26, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @slateny @hello-adam
pythongh-89885: Improve import example in language reference (pythonG…
90d7863 
…H-91523) (python#91649)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit d5a6957)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slateny @JelleZijlstra @miss-islington @bedevere-bot @AlexWaygood