Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90501: Fix refleak in PyErr_SetExcInfo/PyErr_SetHandledException #91627

Merged
merged 1 commit into from Apr 17, 2022
Merged

gh-90501: Fix refleak in PyErr_SetExcInfo/PyErr_SetHandledException #91627

merged 1 commit into from Apr 17, 2022
+2 −3

Conversation

sweeneyde
Copy link
Member

@sweeneyde sweeneyde commented Apr 17, 2022

@sweeneyde sweeneyde requested a review from iritkatriel Apr 17, 2022
@sweeneyde sweeneyde added type-bug 3.11 labels Apr 17, 2022
@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 17, 2022

Thanks. How did you see this? I’m pretty sure I ran the buildbots. Are we missing a test?

@sweeneyde
Copy link
Member Author

@sweeneyde sweeneyde commented Apr 17, 2022

I noticed the failures at https://buildbot.python.org/all/#/release_status

The warnings on s390x RHEL8 Refleaks 3.x:

test_sys_settrace leaked [7420, 7418, 7420] references, sum=22258
test_sys_settrace leaked [2346, 2359, 2356] memory blocks, sum=7061
test_capi leaked [3509, 3507, 3509] references, sum=10525
test_capi leaked [936, 948, 940] memory blocks, sum=2824
test_grammar leaked [1822, 1820, 1822] references, sum=5464
test_grammar leaked [447, 472, 470] memory blocks, sum=1389
test_exception_variations leaked [1104, 1102, 1104] references, sum=3310
test_exception_variations leaked [298, 306, 303] memory blocks, sum=907
test_except_star leaked [8120, 8116, 8120] references, sum=24356
test_except_star leaked [3022, 3024, 3022] memory blocks, sum=9068
0:56:51 load avg: 0.00 Re-running failed tests in verbose mode
0:56:51 load avg: 0.00 Re-running test_sys_settrace in verbose mode
test_sys_settrace leaked [7451, 7449, 7451] references, sum=22351
test_sys_settrace leaked [2357, 2371, 2368] memory blocks, sum=7096
0:56:52 load avg: 0.00 Re-running test_epoll in verbose mode (matching: test_control_and_wait)
0:56:52 load avg: 0.00 Re-running test_capi in verbose mode
0:56:52 load avg: 0.00 Re-running test_grammar in verbose mode
0:56:53 load avg: 0.00 Re-running test_exception_variations in verbose mode
0:56:53 load avg: 0.00 Re-running test_except_star in verbose mode

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Apr 17, 2022

Ok, so the system work. I don’t know how I missed them.

@sweeneyde sweeneyde merged commit 3289209 into python:main Apr 17, 2022
12 checks passed
@sweeneyde sweeneyde deleted the set_handled_refleak branch Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

Assignees
No one assigned
Labels
3.11 skip news type-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sweeneyde @iritkatriel @bedevere-bot