Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] gh-91118: Fix docstrings that do not honor --without-doc-strings (GH-31769) #91662

Merged
merged 2 commits into from Apr 19, 2022
Merged

[3.10] gh-91118: Fix docstrings that do not honor --without-doc-strings (GH-31769) #91662

merged 2 commits into from Apr 19, 2022

Conversation

arhadthedev
Copy link
Contributor

@arhadthedev arhadthedev commented Apr 18, 2022

Co-authored-by: Éric merwok@netwok.org
Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
(cherry picked from commit a573cb2)

Co-authored-by: Oleg Iarygin oleg@arhadthedev.net

@arhadthedev
[3.10] pythongh-91118: Fix docstrings that do not honor --without-doc…
88a96b4 
…-strings (pythonGH-31769)

Co-authored-by: Éric <merwok@netwok.org>
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit a573cb2)

Co-authored-by: Oleg Iarygin <oleg@arhadthedev.net>
@bedevere-bot bedevere-bot mentioned this pull request Apr 18, 2022
Merged
@arhadthedev
Copy link
Contributor Author

@arhadthedev arhadthedev commented Apr 18, 2022

A failed test has no relation with changed docstrings:

== Tests result: ENV CHANGED ==

417 tests OK.

10 slowest tests:
- test_concurrent_futures: 2 min 41 sec
- test_multiprocessing_spawn: 2 min 39 sec
- test_gdb: 2 min 1 sec
- test_multiprocessing_forkserver: 1 min 38 sec
- test_asyncio: 1 min 29 sec
- test_multiprocessing_fork: 1 min 21 sec
- test_peg_generator: 1 min 13 sec
- test_signal: 51.0 sec
- test_subprocess: 43.9 sec
- test_venv: 35.7 sec

1 test altered the execution environment:
    test_asyncio

9 tests skipped:
    test_devpoll test_ioctl test_kqueue test_msilib test_startfile
    test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 9 min 15 sec
Tests result: ENV CHANGED
make: *** [Makefile:1255: buildbottest] Error 3
Error: Process completed with exit code 2.

@arhadthedev arhadthedev deleted the backport-a573cb2-3.10 branch Apr 18, 2022
@arhadthedev arhadthedev restored the backport-a573cb2-3.10 branch Apr 18, 2022
@arhadthedev arhadthedev reopened this Apr 18, 2022
@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 18, 2022 •
edited

A failed test has no relation with changed docstrings:

The test is known to be flaky on the backport branches, for some reason (I think @JelleZijlstra was having trouble with it recently). Not sure that anybody's worked out what the problem is, though.

@JelleZijlstra JelleZijlstra self-requested a review Apr 18, 2022
@JelleZijlstra JelleZijlstra self-assigned this Apr 18, 2022
@AlexWaygood
Copy link
Member

@AlexWaygood AlexWaygood commented Apr 18, 2022 •
edited

A failed test has no relation with changed docstrings:

The test is known to be flaky on the backport branches, for some reason (I think @JelleZijlstra was having trouble with it recently). Not sure that anybody's worked out what the problem is, though.

This looks like it should fix test_asyncio on 3.10:

@arhadthedev
Copy link
Contributor Author

@arhadthedev arhadthedev commented Apr 19, 2022 •
edited

@AlexWaygood A non-reverting fix (#91680) got merged so I've updated this PR. Update: Ubuntu tests now pass.

@JelleZijlstra JelleZijlstra merged commit e7e8a9f into python:3.10 Apr 19, 2022
13 checks passed
@arhadthedev arhadthedev deleted the backport-a573cb2-3.10 branch Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

Assignees

@JelleZijlstra JelleZijlstra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@arhadthedev @AlexWaygood @JelleZijlstra @bedevere-bot