Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91616: re module, fix .fullmatch() mismatch when using Atomic Grouping or Possessive Quantifiers #91681

Merged
merged 3 commits into from Apr 19, 2022
Merged

gh-91616: re module, fix .fullmatch() mismatch when using Atomic Grouping or Possessive Quantifiers #91681

merged 3 commits into from Apr 19, 2022

Conversation

animalize
Copy link
Contributor

@animalize animalize commented Apr 19, 2022 •
edited by serhiy-storchaka

These jumps should use DO_JUMP0() instead of DO_JUMP():

  • JUMP_POSS_REPEAT_1
  • JUMP_POSS_REPEAT_2
  • JUMP_ATOMIC_GROUP

Closes #91616.

animalize added 2 commits Apr 19, 2022
@animalize
add pathlib test-cases
8dbd96d
@animalize
re module, fix .fullmatch() mismatch when using Atomic Grouping / Pos…
06f0a3c 
…sessive Quantifiers

These jumps should use DO_JUMP0() instead of DO_JUMP():
- JUMP_POSS_REPEAT_1
- JUMP_POSS_REPEAT_2
- JUMP_ATOMIC_GROUP
@animalize animalize requested a review from brettcannon as a code owner Apr 19, 2022
@animalize animalize mentioned this pull request Apr 19, 2022
Closed
@AlexWaygood AlexWaygood added expert-regex type-bug An unexpected behavior, bug, or error labels Apr 19, 2022
serhiy-storchaka
serhiy-storchaka reviewed Apr 19, 2022
View changes
Lib/test/test_pathlib.py Outdated Show resolved Hide resolved
Lib/test/test_pathlib.py Outdated Show resolved Hide resolved
Lib/test/test_re.py Show resolved Hide resolved
@serhiy-storchaka serhiy-storchaka merged commit e4e8895 into python:main Apr 19, 2022
13 checks passed
@animalize animalize deleted the re_atomic_bug branch Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka

@brettcannon brettcannon

Assignees
No one assigned
Labels
expert-regex type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Path.rglob fails with *.* on Python 3.11.0a7
4 participants
@animalize @serhiy-storchaka @bedevere-bot @AlexWaygood