Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-91700: Validate the group number in conditional expression in RE #91702

Merged
merged 1 commit into from Apr 22, 2022

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Apr 19, 2022

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code.

Closes #91700.

…n RE

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code.
@serhiy-storchaka serhiy-storchaka merged commit 48ec61a into python:main Apr 22, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 48ec61a89a959071206549819448405c2cea61b0 3.10

@serhiy-storchaka serhiy-storchaka deleted the re-groupref-exists branch Apr 22, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Apr 22, 2022

Sorry @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 48ec61a89a959071206549819448405c2cea61b0 3.9

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Apr 22, 2022
…ssion in RE (pythonGH-91702)

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code..
(cherry picked from commit 48ec61a)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Apr 22, 2022

GH-91831 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka added a commit that referenced this pull request Apr 22, 2022
…in RE (GH-91702) (GH-91831)

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code.
(cherry picked from commit 48ec61a)
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 22, 2022
…ssion in RE (pythonGH-91702) (pythonGH-91831)

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code.
(cherry picked from commit 48ec61a)
(cherry picked from commit 080781c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Apr 22, 2022
…n RE (GH-91702) (GH-91831) (GH-91836)

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code.
(cherry picked from commit 48ec61a)
(cherry picked from commit 080781c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Apr 25, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
…sion in RE (pythonGH-91702) (pythonGH-91831) (pythonGH-91836)

In expression (?(group)...) an appropriate re.error is now
raised if the group number refers to not defined group.

Previously it raised RuntimeError: invalid SRE code.
(cherry picked from commit 48ec61a)
(cherry picked from commit 080781c)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expert-regex type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Internal error when compile RE with conditional expression referring to not defined group
4 participants