Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91731: Build Python with -std=c11 #91733

Merged
merged 1 commit into from Apr 20, 2022
Merged

gh-91731: Build Python with -std=c11 #91733

merged 1 commit into from Apr 20, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Apr 20, 2022

Python is now built with "-std=c11" compiler option, rather than
"-std=c99".

@vstinner vstinner mentioned this pull request Apr 20, 2022
Merged
@vstinner
Copy link
Member Author

@vstinner vstinner commented Apr 20, 2022

cc @encukou @erlend-aasland

@corona10
Copy link
Member

@corona10 corona10 commented Apr 20, 2022 •
edited

@vstinner You should re-generate configure file or hard-coding change :)

@vstinner
pythongh-91731: Build Python with -std=c11
1466ea7 
Python is now built with "-std=c11" compiler option, rather than
"-std=c99".
@vstinner
Copy link
Member Author

@vstinner vstinner commented Apr 20, 2022 •
edited

@vstinner You should re-generate configure file or hard-coding change :)

Oops, right. Done: I ran make regen-configure.

@vstinner
Copy link
Member Author

@vstinner vstinner commented Apr 20, 2022

I checks build logs of macOS and Ubuntu jobs: -std=c11 option is used to build Python core and to build C extensions built as shared libraries.

@vstinner vstinner merged commit aaeea78 into python:main Apr 20, 2022
13 checks passed
@vstinner vstinner deleted the std_c11 branch Apr 20, 2022
@erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Apr 20, 2022

Looks good

@vstinner
Copy link
Member Author

@vstinner vstinner commented Apr 20, 2022

Thanks for the reviews @corona10 and @erlend-aasland.

@vstinner vstinner mentioned this pull request Apr 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vstinner @corona10 @erlend-aasland @bedevere-bot