Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-91078: Return None from TarFile.next when the tarfile is empty #91850

Merged
merged 3 commits into from Nov 26, 2022
Merged

gh-91078: Return None from TarFile.next when the tarfile is empty #91850

merged 3 commits into from Nov 26, 2022

Conversation

dignissimus
Copy link
Contributor

@dignissimus dignissimus commented Apr 23, 2022 •
edited by bedevere-bot

@dignissimus dignissimus requested a review from ethanfurman as a code owner Apr 23, 2022
@dignissimus
Copy link
Contributor Author

dignissimus commented Apr 23, 2022

Would this need to be backported?

@AlexWaygood AlexWaygood added the stdlib Python modules in the Lib dir label May 4, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 26, 2022
Closed
iritkatriel
iritkatriel approved these changes Nov 26, 2022
View changes
Copy link
Member

@iritkatriel iritkatriel left a comment

LGTM.

@ethanfurman what's your view on back porting this?

@iritkatriel iritkatriel changed the title gh-91078: Return None in TarFile.next when the tarfile is empty gh-91078: Return None from TarFile.next when the tarfile is empty Nov 26, 2022
@ethanfurman ethanfurman merged commit 78365b8 into python:main Nov 26, 2022
15 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Nov 26, 2022

Thanks @dignissimus for the PR, and @ethanfurman for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Nov 26, 2022

GH-99798 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 26, 2022
@dignissimus @iritkatriel @miss-islington
pythongh-91078: Return None from TarFile.next when the tarfile is emp…
db58c93 
…ty (pythonGH-91850)

(cherry picked from commit 78365b8)

Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
@ethanfurman
Copy link
Member

ethanfurman commented Nov 26, 2022

@iritkatriel Backporting sounds good, thanks for the help.

@dignissimus Thanks for the work, sorry it took so long to get merged.

miss-islington added a commit that referenced this pull request Nov 26, 2022
@miss-islington @dignissimus @iritkatriel
gh-91078: Return None from TarFile.next when the tarfile is empty (GH…
193a25e 
…-91850)

(cherry picked from commit 78365b8)

Co-authored-by: Sam Ezeh <sam.z.ezeh@gmail.com>
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iritkatriel iritkatriel

@ethanfurman ethanfurman

Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tarfile.TarFile.next() crashes on empty tar files
6 participants
@dignissimus @miss-islington @bedevere-bot @ethanfurman @iritkatriel @AlexWaygood