derive(TryIntoPyStructSequence) #3613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowone
force-pushed
the
pystructseq-fromobj
branch
from
01ef615 to
7cd2b8b
Compare
Merged
youknowone
force-pushed
the
pystructseq-fromobj
branch
3 times, most recently
from
5d810e4 to
899e794
Compare
Merged
coolreader18
approved these changes
Apr 19, 2022
| impl ::rustpython_vm::TryFromObject for #ty { | ||
| fn try_from_object(vm: &::rustpython_vm::VirtualMachine, seq: ::rustpython_vm::PyObjectRef) -> ::rustpython_vm::PyResult<Self> { | ||
| let seq = Self::try_elements_from(seq, vm)?; | ||
| let mut iter = seq.into_iter(); |
There was a problem hiding this comment.
Yeah, this could probably be let seq: [PyObjectRef; <#ty as ::rustpython_vm::types::PyStructSeq>::FIELD_NAMES.len()] = seq.try_into().unwrap();
There was a problem hiding this comment.
no idea how to handle index in quote!()
youknowone
force-pushed
the
pystructseq-fromobj
branch
from
899e794 to
41000c4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.