Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-84714: Add behavior if dst file exists #91867

Merged
merged 2 commits into from May 2, 2022
Merged

gh-84714: Add behavior if dst file exists #91867

merged 2 commits into from May 2, 2022

Conversation

slateny
Copy link
Contributor

@slateny slateny commented Apr 24, 2022

#84714

Skipped copy2 since it says

Identical to copy() except that copy2() also attempts to preserve file metadata.

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Apr 24, 2022
@slateny
Copy link
Contributor Author

slateny commented Apr 25, 2022

@AlexWaygood Could you throw in the skip-news label for this one?

@AlexWaygood
Copy link
Member

AlexWaygood commented Apr 25, 2022

@AlexWaygood Could you throw in the skip-news label for this one?

C'est fait

JelleZijlstra
JelleZijlstra reviewed Apr 30, 2022
View changes
Doc/library/shutil.rst Outdated Show resolved Hide resolved
@JelleZijlstra JelleZijlstra merged commit 9166ace into python:main May 2, 2022
13 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Sorry @slateny and @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 9166ace805d915c8a918cd89fff0e58b65e3327c 3.10

@bedevere-bot
Copy link

bedevere-bot commented May 2, 2022

GH-92143 is a backport of this pull request to the 3.9 branch.

@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 2, 2022

GH-92144 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@slateny @miss-islington
pythongh-84714: Add behavior if dst file exists (pythonGH-91867)
3beef5d 
(cherry picked from commit 9166ace)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @slateny
gh-84714: Add behavior if dst file exists (GH-91867)
bba721d 
(cherry picked from commit 9166ace)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @slateny
gh-84714: Add behavior if dst file exists (GH-91867)
cafcb2c 
(cherry picked from commit 9166ace)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
@slateny slateny deleted the s/shutil branch May 4, 2022
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@miss-islington @slateny @hello-adam
pythongh-84714: Add behavior if dst file exists (pythonGH-91867)
5c07a84 
(cherry picked from commit 9166ace)

Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelleZijlstra JelleZijlstra

Assignees

@JelleZijlstra JelleZijlstra

Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@slateny @AlexWaygood @miss-islington @bedevere-bot @JelleZijlstra