Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-1635741: Fix winreg reference leaks #31560

Merged
merged 1 commit into from Feb 25, 2022
Merged

bpo-1635741: Fix winreg reference leaks #31560

merged 1 commit into from Feb 25, 2022

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Feb 25, 2022 •
edited by bedevere-bot

Clear also the PyHKEY_Type static type at exit.

https://bugs.python.org/issue1635741

@vstinner
bpo-1635741: Fix winreg reference leaks
bb8dbca 
Clear also the PyHKEY_Type static type at exit.
@vstinner vstinner requested a review from as a code owner Feb 25, 2022
@vstinner
Copy link
Member Author

@vstinner vstinner commented Feb 25, 2022

With this range, it remains a leak of 1 reference on Windows:

$ python -I -X showrefcount -c pass
[1 refs, 1 blocks]

@vstinner vstinner mentioned this pull request Feb 25, 2022
Merged
@vstinner vstinner merged commit 4657bf7 into python:main Feb 25, 2022
11 checks passed
@vstinner vstinner deleted the winreg_refleak branch Feb 25, 2022
asvetlov added a commit that referenced this issue Feb 26, 2022
@vstinner @asvetlov
bpo-1635741: Fix winreg reference leaks (GH-31560)
c6d0b5e 
Clear also the PyHKEY_Type static type at exit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@python/windows-team windows-team

Assignees
No one assigned
Labels
CLA signed skip news
Projects
None yet
Milestone
No milestone
3 participants
@vstinner @the-knights-who-say-ni @bedevere-bot