Misc. typos #4275

luzpaz · 2017-11-04T11:47:53Z

Most are trivial. Some are user facing. Found using:
codespell -q 3 -I '../cpy-whitelist.txt'
whereby the whitelist contained:

ans
dum
efford
iff
ot
nto
que
teh
te
thru
upto
whitespaces

the-knights-who-say-ni · 2017-11-04T11:47:55Z

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

luzpaz · 2017-11-04T12:20:42Z

Is it OK if I don't sign CLA.. I hereby release all trivial changes I am requesting for merge to the cpython project.

skrah · 2017-11-04T12:50:49Z

Lib/test/decimaltestdata/abs.decTest

@@ -20,7 +20,7 @@
 version: 2.59

 -- This set of tests primarily tests the existence of the operator.
-- Additon, subtraction, rounding, and more overflows are tested


The test data is from a third party, so please take this change out. It does not make sense to maintain our own version.

all test data or just this file?

I am sure just this file.

terryjreedy

With the exception of the ambigous 'catched', the replacements are correct.

terryjreedy · 2017-11-04T18:52:40Z

Lib/test/support/__init__.py

@@ -2770,7 +2770,7 @@ def __init__(self):
        import signal
        self.signal = signal
        self.signals = list(range(1, signal.NSIG))
-        # SIGKILL and SIGSTOP signals cannot be ignored nor catched
+        # SIGKILL and SIGSTOP signals cannot be ignored nor caught


'catched' might be a misspelling of 'cached' rather than 'caught'. Victor Stinner might be the one who knows.

this edit is correct: "caught" was intended.

Oops, irregular verb: caught is correct ;-)

terryjreedy · 2017-11-04T18:52:40Z

Lib/test/decimaltestdata/abs.decTest

@@ -20,7 +20,7 @@
 version: 2.59

 -- This set of tests primarily tests the existence of the operator.
-- Additon, subtraction, rounding, and more overflows are tested


I am sure just this file.

bedevere-bot · 2017-11-04T18:52:42Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

terryjreedy · 2017-11-04T19:03:04Z

Luzpaz: is your reluctance to sign the CLA the inconvenience of setting up a bpo account, or an objection to the CLA itself? (The actual e-signing is pretty trivial.)

If you only had submitted a couple of typos, there would be no issue (other than the fact we would hope to see more submissions from you). I am not sure about 58 (but please don't split this into 29 obviously trivial PRs ;-). Brett, your bot -- what is your opinion?

it comes from an external source so we should leave the typo as is.

terryjreedy · 2017-11-04T19:12:24Z

The Travis failure is due to whitespace issues for
Include/pymem.h
Modules/_posixsubprocess.c
These were probably pre-existing. I will see if patchcheck on Windows fixes them.

gpshead · 2017-11-04T19:20:02Z

FWIW as all of these are trivially correct obvious documentation or comment typo fixes my inclination is to not worry about the CLA being signed regardless of number of files. I'll be happy to merge this either way.

serhiy-storchaka · 2017-11-04T19:29:11Z

Doc/license.rst

@@ -788,7 +788,7 @@ of the OpenSSL license here::
     * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
     * SUCH DAMAGE.
     *
-     * The licence and distribution terms for any publically available version or
+     * The licence and distribution terms for any publicly available version or


You can't just change the license text, especially if this is a license of imported code.

serhiy-storchaka · 2017-11-04T19:29:11Z

Doc/whatsnew/3.2.rst

@@ -164,7 +164,7 @@ each with their own argument patterns and help displays::

    $ ./helm.py --help                         # top level help (launch and move)
    $ ./helm.py launch --help                  # help for launch options
-    $ ./helm.py launch --missiles              # set missiles=True and torpedos=False
+    $ ./helm.py launch --missiles              # set missiles=True and torpedoes=False


The option name is torpedos.

serhiy-storchaka · 2017-11-04T19:29:11Z

aclocal.m4

@@ -100,7 +100,7 @@ dnl Check to see whether a particular set of modules exists. Similar to
 dnl PKG_CHECK_MODULES(), but does not set variables or print errors.
 dnl
 dnl Please remember that m4 expands AC_REQUIRE([PKG_PROG_PKG_CONFIG])
-dnl only at the first occurence in configure.ac, so if the first place
+dnl only at the first occurrence in configure.ac, so if the first place


Isn't this an imported file?

serhiy-storchaka · 2017-11-04T19:29:11Z

Doc/whatsnew/3.3.rst

@@ -1504,7 +1504,7 @@ argument taking an iterable of handlers to be added to the root logger.
 A class level attribute :attr:`~logging.handlers.SysLogHandler.append_nul` has
 been added to :class:`~logging.handlers.SysLogHandler` to allow control of the
 appending of the ``NUL`` (``\000``) byte to syslog records, since for some
-deamons it is required while for others it is passed through to the log.
+daemons it is required while for others it is passed through to the log.


Please fix the same typo in Lib/test/test_threading.py.

@serhiy-storchaka apologies, are you saying that daemons is correct here?
and in regards to Lib/test/test_threading.py i should fix:

cpython/Lib/test/test_threading.py

Line 430 in 1023dbb

def test_deamon_param(self):

so that it shows:
def test_daemon_param(self):

gpshead

awaiting resolution of Serhiy's comments.

bedevere-bot · 2017-11-04T19:31:31Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

luzpaz · 2017-11-04T21:01:16Z

I will resubmit PR very soon with requested changes.

terryjreedy · 2017-11-04T21:38:00Z

I hope you mean to push a new commit to this PR rather than closing this and submitting a new PR.

luzpaz · 2017-11-05T13:00:27Z

I have made the requested changes; please review again

Sorry folks, my git-fu skills are pretty sad. Not sure how to squash everything in to 1 commit at this moment.

bedevere-bot · 2017-11-05T13:00:29Z

Thanks for making the requested changes!

@gpshead, @terryjreedy: please review the changes made to this pull request.

serhiy-storchaka

Thank you. You shouldn't squash everything into 1 commit. It is easier to review if keep separate incremental changes. All this will be squashed into 1 commit when be merged into master.

Manual partial backport of patch that fixed nearly 50 other files.

vstinner

I plead guilty for "informations": I cannot accept that it's not possible to put a S to information in english! Sorry, I'm french :-)

vstinner · 2017-11-06T09:25:16Z

Lib/test/support/__init__.py

@@ -2770,7 +2770,7 @@ def __init__(self):
        import signal
        self.signal = signal
        self.signals = list(range(1, signal.NSIG))
-        # SIGKILL and SIGSTOP signals cannot be ignored nor catched
+        # SIGKILL and SIGSTOP signals cannot be ignored nor caught


Oops, irregular verb: caught is correct ;-)

vstinner · 2017-11-06T09:25:32Z

Thanks for fixing all these typos!

Misc. typos

56bf281

luzpaz requested review from 1st1, gpshead, rhettinger, skrah, terryjreedy and as code owners Nov 4, 2017

the-knights-who-say-ni added the CLA not signed label Nov 4, 2017

bedevere-bot added the awaiting review label Nov 4, 2017

skrah reviewed Nov 4, 2017

View changes

terryjreedy requested a review from vstinner Nov 4, 2017

terryjreedy requested changes Nov 4, 2017

View changes

bedevere-bot added awaiting changes and removed awaiting review labels Nov 4, 2017

terryjreedy requested a review from brettcannon Nov 4, 2017

reverting the change in this file

b8b1a7e

it comes from an external source so we should leave the typo as is.

gpshead approved these changes Nov 4, 2017

View changes

bedevere-bot added awaiting merge and removed awaiting changes labels Nov 4, 2017

Fix whitespace.

0d3a46c

gpshead added skip issue skip news labels Nov 4, 2017

terryjreedy approved these changes Nov 4, 2017

View changes

serhiy-storchaka reviewed Nov 4, 2017

View changes

gpshead requested changes Nov 4, 2017

View changes

bedevere-bot removed the awaiting merge label Nov 4, 2017

bedevere-bot added the awaiting changes label Nov 4, 2017

Unknown added 2 commits Nov 5, 2017

Revise commit per maintainers feedback

c528f5e

Merge remote-tracking branch 'origin/typos' into typos

29e5525

bedevere-bot added awaiting change review and removed awaiting changes labels Nov 5, 2017

serhiy-storchaka approved these changes Nov 5, 2017

View changes

bedevere-bot added awaiting merge and removed awaiting change review labels Nov 5, 2017

serhiy-storchaka merged commit a5293b4 into python:master Nov 5, 2017
4 checks passed

bedevere-bot removed the awaiting merge label Nov 5, 2017

luzpaz deleted the typos branch Nov 5, 2017

terryjreedy added a commit to terryjreedy/cpython that referenced this issue Nov 5, 2017

[3.6] Fix miscellaneous typos in idlelib (pythonGH-4275)

6c46213

Manual partial backport of patch that fixed nearly 50 other files.

terryjreedy added a commit that referenced this issue Nov 6, 2017

[3.6] Fix miscellaneous typos in idlelib (GH-4275) (#4291)

646e4c8

Manual partial backport of patch that fixed nearly 50 other files.

vstinner reviewed Nov 6, 2017

View changes

embray pushed a commit to embray/cpython that referenced this issue Nov 9, 2017

Fix miscellaneous typos (python#4275)

5bf87bc

Misc. typos #4275

Misc. typos #4275

luzpaz commented Nov 4, 2017

the-knights-who-say-ni commented Nov 4, 2017

luzpaz commented Nov 4, 2017

skrah Nov 4, 2017

luzpaz Nov 4, 2017

terryjreedy Nov 4, 2017

terryjreedy left a comment

terryjreedy Nov 4, 2017

gpshead Nov 4, 2017

vstinner Nov 6, 2017

terryjreedy Nov 4, 2017

bedevere-bot commented Nov 4, 2017

terryjreedy commented Nov 4, 2017

terryjreedy commented Nov 4, 2017

gpshead commented Nov 4, 2017

serhiy-storchaka Nov 4, 2017

serhiy-storchaka Nov 4, 2017

serhiy-storchaka Nov 4, 2017

serhiy-storchaka Nov 4, 2017

luzpaz Nov 4, 2017

gpshead left a comment

bedevere-bot commented Nov 4, 2017

luzpaz commented Nov 4, 2017

terryjreedy commented Nov 4, 2017

luzpaz commented Nov 5, 2017

bedevere-bot commented Nov 5, 2017

serhiy-storchaka left a comment

vstinner left a comment

vstinner Nov 6, 2017

vstinner commented Nov 6, 2017

Misc. typos #4275

Misc. typos #4275

Conversation

luzpaz commented Nov 4, 2017

the-knights-who-say-ni commented Nov 4, 2017

luzpaz commented Nov 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

terryjreedy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bedevere-bot commented Nov 4, 2017

terryjreedy commented Nov 4, 2017

terryjreedy commented Nov 4, 2017

gpshead commented Nov 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gpshead left a comment

bedevere-bot commented Nov 4, 2017

luzpaz commented Nov 4, 2017

terryjreedy commented Nov 4, 2017

luzpaz commented Nov 5, 2017

bedevere-bot commented Nov 5, 2017

serhiy-storchaka left a comment

vstinner left a comment

Choose a reason for hiding this comment

vstinner commented Nov 6, 2017