feat(core): allow to throw on unknown elements in tests #45479

cexbrayat · 2022-03-30T17:19:15Z

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Feature

What is the current behavior?

In a test, when using an unknown element in a template, we just get a console error.

Issue Number: #36430

What is the new behavior?

Allows to provide a TestBed option to throw on unknown elements in templates:

getTestBed().initTestEnvironment(
  BrowserDynamicTestingModule,
  platformBrowserDynamicTesting(),
  { errorOnUnknownElements: true }
);

Does this PR introduce a breaking change?

The default value of throwOnUnknownElement is false, so this is not a breaking change.

Yes
No

google-cla · 2022-03-30T17:19:22Z

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

AndrewKushnir

@cexbrayat thanks for creating this PR! 👍
The changes look great, just left a few minor comments.

packages/core/test/acceptance/ng_module_spec.ts

packages/core/src/render3/index.ts

packages/core/src/render3/instructions/element.ts

packages/core/test/acceptance/ng_module_spec.ts

packages/core/testing/src/r3_test_bed.ts

goldens/public-api/core/testing/index.md

packages/core/src/render3/instructions/element.ts

packages/core/test/acceptance/ng_module_spec.ts

packages/core/testing/src/test_bed_common.ts

packages/core/testing/src/r3_test_bed.ts

AndrewKushnir

@cexbrayat the changes look good, thanks Cedric!

We've discussed this change during the team sync and this looks like the approach we want to take. This approach allows us to enable this by default (in one of the next major versions) and use this mechanism for opt-out.

jessicajaniuk

reviewed-for: public-api

jelbourn

LGTM

Reviewed-for: public-api

goldens/public-api/core/testing/index.md

cexbrayat · 2022-04-29T18:10:05Z

We agreed with @AndrewKushnir that errorOnUnknownElements was probably a better name, as @atscott and @jelbourn suggested. I updated the PR to use errorOnUnknownElements instead of throwOnUnknownElements

Allows to provide a TestBed option to throw on unknown elements in templates: ```ts getTestBed().initTestEnvironment( BrowserDynamicTestingModule, platformBrowserDynamicTesting(), { errorOnUnknownElements: true } ); ``` The default value of `errorOnUnknownElements` is `false`, so this is not a breaking change.

AndrewKushnir · 2022-04-29T21:20:05Z

Presubmit (note: this change would also require this update in g3) + TGP.

AndrewKushnir · 2022-04-30T18:54:10Z

FYI, the presubmit went well and I'm adding this PR to the merge queue.

dylhunn · 2022-05-02T16:22:36Z

This PR was merged into the repository by commit 6662a97.

…lar#45479)" This reverts commit 6662a97.

…)" (#45839) This reverts commit 6662a97. PR Close #45839

dylhunn · 2022-05-02T16:37:14Z

Rolled this back temporarily because I didn't see the g3 patch above. I will roll forward again and sync with the patch.

dylhunn · 2022-05-02T16:38:14Z

This PR was merged into the repository by commit e702caf.

angular-automatic-lock-bot · 2022-06-02T16:06:13Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

cexbrayat force-pushed the feat/throw-on-unknown-element branch 2 times, most recently from 68cd385 to 18af293 Compare Mar 30, 2022

dylhunn added the comp: core label Mar 30, 2022

ngbot bot added this to the Backlog milestone Mar 30, 2022

AndrewKushnir reviewed Mar 31, 2022

View changes

AndrewKushnir added the state: WIP label Mar 31, 2022

cexbrayat mentioned this pull request Mar 31, 2022

refactor(core): validate element is known in JIT mode #45492

Closed

14 tasks

cexbrayat force-pushed the feat/throw-on-unknown-element branch 7 times, most recently from 052f49f to 67ce006 Compare Apr 5, 2022

cexbrayat force-pushed the feat/throw-on-unknown-element branch 3 times, most recently from 464a47e to ce828a7 Compare Apr 19, 2022

cexbrayat marked this pull request as ready for review Apr 19, 2022

AndrewKushnir reviewed Apr 19, 2022

View changes

cexbrayat force-pushed the feat/throw-on-unknown-element branch 2 times, most recently from 6a02152 to 6b556e3 Compare Apr 20, 2022

AndrewKushnir added action: review target: major and removed state: WIP labels Apr 20, 2022

AndrewKushnir removed this from the Backlog milestone Apr 20, 2022

AndrewKushnir added this to the v14-candidates milestone Apr 20, 2022

AndrewKushnir approved these changes Apr 22, 2022

View changes

pullapprove bot requested review from alxhub and AndrewKushnir Apr 22, 2022

jessicajaniuk approved these changes Apr 25, 2022

View changes

jelbourn approved these changes Apr 29, 2022

View changes

goldens/public-api/core/testing/index.md Outdated Show resolved Hide resolved

cexbrayat force-pushed the feat/throw-on-unknown-element branch 2 times, most recently from 4129e51 to 5e2a608 Compare Apr 29, 2022

cexbrayat force-pushed the feat/throw-on-unknown-element branch from 5e2a608 to 1d169e8 Compare Apr 29, 2022

AndrewKushnir added feature action: presubmit and removed action: review labels Apr 29, 2022

AndrewKushnir removed request for alxhub and dylhunn Apr 30, 2022

AndrewKushnir approved these changes Apr 30, 2022

View changes

AndrewKushnir added action: merge and removed action: presubmit labels Apr 30, 2022

dylhunn closed this in 6662a97 May 2, 2022

dylhunn added a commit to dylhunn/angular that referenced this issue May 2, 2022

Revert "feat(core): allow to throw on unknown elements in tests (angu…

c67d81c

…lar#45479)" This reverts commit 6662a97.

dylhunn added a commit that referenced this issue May 2, 2022

Revert "feat(core): allow to throw on unknown elements in tests (#45479…

6a3ca0e

…)" (#45839) This reverts commit 6662a97. PR Close #45839

dylhunn reopened this May 2, 2022

dylhunn closed this in e702caf May 2, 2022

cexbrayat mentioned this pull request May 3, 2022

feat(core): allow to throw on unknown properties in tests #45853

Closed

6 tasks

angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2022

feat(core): allow to throw on unknown elements in tests #45479

feat(core): allow to throw on unknown elements in tests #45479

cexbrayat commented Mar 30, 2022 •

edited

google-cla bot commented Mar 30, 2022

AndrewKushnir left a comment

AndrewKushnir left a comment

jessicajaniuk left a comment

jelbourn left a comment

cexbrayat commented Apr 29, 2022

AndrewKushnir commented Apr 29, 2022 •

edited

AndrewKushnir commented Apr 30, 2022

dylhunn commented May 2, 2022

dylhunn commented May 2, 2022 •

edited

dylhunn commented May 2, 2022

angular-automatic-lock-bot bot commented Jun 2, 2022

feat(core): allow to throw on unknown elements in tests #45479

feat(core): allow to throw on unknown elements in tests #45479

Conversation

cexbrayat commented Mar 30, 2022 • edited

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

google-cla bot commented Mar 30, 2022

AndrewKushnir left a comment

AndrewKushnir left a comment

jessicajaniuk left a comment

jelbourn left a comment

cexbrayat commented Apr 29, 2022

AndrewKushnir commented Apr 29, 2022 • edited

AndrewKushnir commented Apr 30, 2022

dylhunn commented May 2, 2022

dylhunn commented May 2, 2022 • edited

dylhunn commented May 2, 2022

angular-automatic-lock-bot bot commented Jun 2, 2022

cexbrayat commented Mar 30, 2022 •

edited

AndrewKushnir commented Apr 29, 2022 •

edited

dylhunn commented May 2, 2022 •

edited