Skip to content

Standalone folowup tests #45709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Standalone folowup tests #45709

wants to merge 1 commit into from

Conversation

pkozlowski-opensource
Copy link
Member

@pkozlowski-opensource pkozlowski-opensource commented Apr 21, 2022 •
edited
Loading

Add more tests verifying the following conditions:

  • discovery of DI providers from exported NgModules
  • forwardRef in standalone component imports

JoostK
JoostK reviewed Apr 21, 2022
View reviewed changes
@pkozlowski-opensource pkozlowski-opensource force-pushed the standalone_folowup_tests branch 4 times, most recently from 1e9e558 to 1d0aa45 Compare April 21, 2022 11:42
@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Apr 21, 2022
Closed
3 tasks
@pkozlowski-opensource
test(core): add more tests for the standalone components
e3686c6 
Add more tests verifying the following conditions:
- discovery of DI providers from exported NgModules
- forwardRef in standalone component imports
@pkozlowski-opensource pkozlowski-opensource added target: minor This PR is targeted for the next minor release action: review The PR is still awaiting reviews from at least one requested reviewer area: core Issues related to the framework runtime labels Apr 27, 2022
@ngbot ngbot bot modified the milestone: Backlog Apr 27, 2022
@pkozlowski-opensource pkozlowski-opensource added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 27, 2022
@atscott
Copy link
Contributor

atscott commented Apr 27, 2022

This PR was merged into the repository by commit 39c1681.

@atscott atscott closed this in 39c1681 Apr 27, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JoostK JoostK JoostK approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker area: core Issues related to the framework runtime target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.
3 participants
@pkozlowski-opensource @atscott @JoostK