Disable x86 specific prctl on aarch64 #3170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocallahan
requested changes
Apr 18, 2022
src/Task.cc
Outdated
| @@ -112,13 +112,15 @@ void Task::detach() { | |||
| } | |||
|
|
|||
| void Task::reenable_cpuid_tsc() { | |||
| #if defined(__i386__) || defined(__x86_64__) | |||
There was a problem hiding this comment.
Instead of conditional compilation how about just checking if (Arch::is_x86ish())?
There was a problem hiding this comment.
Fewer #ifdefs means less cross-platform compilation bustage.
These are documented in the manual as x86-only. Even if we have a version for aarch64/other arch with similar function, they'll probably have a different name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are documented in the manual as x86-only.
Even if we have a version for aarch64/other arch with similar function, they'll probably have a different name.